mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Brendan Jackman <brendan.jackman@arm.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@redhat.com>,
	Morten Rasmussen <morten.rasmussen@arm.com>
Subject: Re: [PATCH 1/2] sched: force update of blocked load of idle cpus
Date: Thu, 30 Nov 2017 15:59:01 +0000	[thread overview]
Message-ID: <87mv33u5a2.fsf@arm.com> (raw)
In-Reply-To: <CAKfTPtDu33pC-VofPzkcW9=f1KN-LsezAQnupjb93iE2RYkLWw@mail.gmail.com>

Hi Vincent,

On Mon, Nov 20 2017 at 09:04, Vincent Guittot wrote:
> On 24 October 2017 at 14:25, Brendan Jackman <brendan.jackman@arm.com> wrote:
>> @@ -9062,7 +9109,12 @@ static __latent_entropy void run_rebalance_domains(struct softirq_action *h)
>>          * and abort nohz_idle_balance altogether if we pull some load.
>>          */
>>         nohz_idle_balance(this_rq, idle);
>> -       rebalance_domains(this_rq, idle);
>> +       update_blocked_averages(this_rq->cpu);
>> +       if (!test_bit(NOHZ_STATS_KICK, nohz_flags(this_rq->cpu)))
>
> The NOHZ_STATS_KICK field is only defined with CONFIG_NO_HZ_COMMON.

Damn, sorry. Will fix this and the similar issue you pointed out on
patch 2/2 and send a v2.

Thanks for reviewing,
Brendan

  reply	other threads:[~2017-11-30 15:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-24 12:25 [PATCH 0/2] sched/fair: remote load updates for idle CPUs Brendan Jackman
2017-10-24 12:25 ` [PATCH 1/2] sched: force update of blocked load of idle cpus Brendan Jackman
2017-11-09 19:56   ` Todd Kjos
2017-11-10 14:53     ` Brendan Jackman
2017-11-20  9:04   ` Vincent Guittot
2017-11-30 15:59     ` Brendan Jackman [this message]
2017-10-24 12:25 ` [PATCH 2/2] sched/fair: Update blocked load from newly idle balance Brendan Jackman
2017-11-20  9:07   ` Vincent Guittot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mv33u5a2.fsf@arm.com \
    --to=brendan.jackman@arm.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=morten.rasmussen@arm.com \
    --cc=peterz@infradead.org \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome