From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933302AbdKGNDD (ORCPT ); Tue, 7 Nov 2017 08:03:03 -0500 Received: from canardo.mork.no ([148.122.252.1]:59759 "EHLO canardo.mork.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932208AbdKGNDB (ORCPT ); Tue, 7 Nov 2017 08:03:01 -0500 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= To: Kristian Evensen Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] qmi_wwan: Add missing skb_reset_mac_header-call Organization: m References: <20171107124756.3029-1-kristian.evensen@gmail.com> Date: Tue, 07 Nov 2017 14:02:53 +0100 In-Reply-To: <20171107124756.3029-1-kristian.evensen@gmail.com> (Kristian Evensen's message of "Tue, 7 Nov 2017 13:47:56 +0100") Message-ID: <87mv3ynsw2.fsf@miraculix.mork.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vA7D37LB002257 Kristian Evensen writes: > When we receive a packet on a QMI device in raw IP mode, we should call > skb_reset_mac_header() to ensure that skb->mac_header contains a valid > offset in the packet. While it shouldn't really matter, the packets have > no MAC header and the interface is configured as-such, it seems certain > parts of the network stack expects a "good" value in skb->mac_header. Thanks. Yes, I see that the tun driver also does this. Acked-by: Bjørn Mork And his should probably go to stable as well? with a Fixes: 32f7adf633b9 ("net: qmi_wwan: support "raw IP" mode")