From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932429AbdJXJpX (ORCPT <rfc822;w@1wt.eu>);
        Tue, 24 Oct 2017 05:45:23 -0400
Received: from mga05.intel.com ([192.55.52.43]:53968 "EHLO mga05.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752166AbdJXJpT (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 24 Oct 2017 05:45:19 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.43,427,1503385200"; 
   d="scan'208";a="913108258"
From: Jani Nikula <jani.nikula@linux.intel.com>
To: David Binderman <dcb314@hotmail.com>,
        "patrik.r.jakobsson\@gmail.com" <patrik.r.jakobsson@gmail.com>,
        "airlied\@linux.ie" <airlied@linux.ie>,
        "dri-devel\@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: drivers/gpu/drm/gma500/mdfld_intel_display.c:102:37: warning: bitwise comparison always evaluates to false [-Wtautological-compare]
In-Reply-To: <HE1PR0802MB233133226542350C51A759889C470@HE1PR0802MB2331.eurprd08.prod.outlook.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
References: <VI1PR0802MB2336FE2CC4B113AD21AAB1CD9C460@VI1PR0802MB2336.eurprd08.prod.outlook.com> <87po9dhqoi.fsf@intel.com> <HE1PR0802MB233133226542350C51A759889C470@HE1PR0802MB2331.eurprd08.prod.outlook.com>
Date: Tue, 24 Oct 2017 12:46:46 +0300
Message-ID: <87mv4gj2t5.fsf@intel.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 24 Oct 2017, David Binderman <dcb314@hotmail.com> wrote:
> Hello there,
>
>
> Code I looked at is in linux-4.14-rc6, released 20171023, so reasonably
>
> up to date.
>
>
> I did a further check on github.com/torvalds/linux and the code
>
> looks wrong there, too.
>
>
> So I don't see the fix you mentioned in either of the places I looked.

It's in drm-next branch of [1] heading for v4.15. Please see MAINTAINERS
in the kernel source root for all the trees.

BR,
Jani.


[1] https://cgit.freedesktop.org/~airlied/linux/


>
>
> Regards
>
>
> David Binderman
>
> ________________________________
> From: Jani Nikula <jani.nikula@linux.intel.com>
> Sent: 24 October 2017 08:54
> To: David Binderman; patrik.r.jakobsson@gmail.com; airlied@linux.ie; dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org
> Subject: Re: drivers/gpu/drm/gma500/mdfld_intel_display.c:102:37: warning: bitwise comparison always evaluates to false [-Wtautological-compare]
>
> On Mon, 23 Oct 2017, David Binderman <dcb314@hotmail.com> wrote:
>> Hello there,
>>
>> Source code is
>>
>>         if ((temp & PIPEACONF_PIPE_STATE) == 1)
>>             break;
>>
>> but
>>
>> $ fgrep PIPEACONF_PIPE_STATE `find drivers/gpu/drm/gma500 -name \*.h -print`
>> drivers/gpu/drm/gma500/psb_intel_reg.h:#define PIPEACONF_PIPE_STATE           (1 << 30)
>> $
>>
>> Suggest new code
>>
>>         if ((temp & PIPEACONF_PIPE_STATE) != 0)
>>             break;
>
> Suggest looking at latest sources. ;)
>
> Fixed by 67a3b63a54cb ("drm: gma500: fix logic error").
>
> BR,
> Jani.
>
> --
> Jani Nikula, Intel Open Source Technology Center

-- 
Jani Nikula, Intel Open Source Technology Center