From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752511AbdGUGe0 (ORCPT ); Fri, 21 Jul 2017 02:34:26 -0400 Received: from ozlabs.org ([103.22.144.67]:47551 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750793AbdGUGeZ (ORCPT ); Fri, 21 Jul 2017 02:34:25 -0400 From: Michael Ellerman To: Zhao Qiang , oss@buserror.net Cc: valentin.longchamp@keymile.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Zhao Qiang Subject: Re: [PATCH] qe: fix compile issue for arm64 In-Reply-To: <1500603550-5567-1-git-send-email-qiang.zhao@nxp.com> References: <1500603550-5567-1-git-send-email-qiang.zhao@nxp.com> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Fri, 21 Jul 2017 16:34:23 +1000 Message-ID: <87mv7ye1sg.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Zhao Qiang writes: > Signed-off-by: Zhao Qiang > --- > drivers/soc/fsl/qe/qe.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/soc/fsl/qe/qe.c b/drivers/soc/fsl/qe/qe.c > index 2ef6fc6..d48fa4a 100644 > --- a/drivers/soc/fsl/qe/qe.c > +++ b/drivers/soc/fsl/qe/qe.c > @@ -229,7 +229,9 @@ int qe_setbrg(enum qe_clock brg, unsigned int rate, unsigned int multiplier) > /* Errata QE_General4, which affects some MPC832x and MPC836x SOCs, says > that the BRG divisor must be even if you're not using divide-by-16 > mode. */ > +#ifdef CONFIG_PPC > if (pvr_version_is(PVR_VER_836x) || pvr_version_is(PVR_VER_832x)) > +#endif > if (!div16 && (divisor & 1) && (divisor > 3)) > divisor++; Are you sure that's what you want to do on arm64 ? cheers