From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756100AbdGLKoQ (ORCPT ); Wed, 12 Jul 2017 06:44:16 -0400 Received: from ozlabs.org ([103.22.144.67]:40127 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750959AbdGLKoO (ORCPT ); Wed, 12 Jul 2017 06:44:14 -0400 From: Michael Ellerman To: Palmer Dabbelt Cc: yamada.masahiro@socionext.com, mmarek@suse.com, will.deacon@arm.com, peterz@infradead.org, boqun.feng@gmail.com, mingo@redhat.com, daniel.lezcano@linaro.org, tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com, gregkh@linuxfoundation.org, jslaby@suse.com, davem@davemloft.net, mchehab@kernel.org, sfr@canb.auug.org.au, fweisbec@gmail.com, viro@zeniv.linux.org.uk, mcgrof@kernel.org, dledford@redhat.com, bart.vanassche@sandisk.com, sstabellini@kernel.org, daniel.vetter@ffwll.ch, msalter@redhat.com, nicolas.dichtel@6wind.com, james.hogan@imgtec.com, paul.gortmaker@windriver.com, linux@roeck-us.net, heiko.carstens@de.ibm.com, schwidefsky@de.ibm.com, linux-kernel@vger.kernel.org, patches@groups.riscv.org, akpm@linux-foundation.org, albert@sifive.com Subject: Re: [PATCH 17/17] RISC-V: Build Infastructure In-Reply-To: References: User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Wed, 12 Jul 2017 20:44:11 +1000 Message-ID: <87mv8akk90.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Palmer Dabbelt writes: > On Mon, 10 Jul 2017 23:31:18 PDT (-0700), mpe@ellerman.id.au wrote: ... >> So if you have a functional early console (which I think you do) then >> you might be better off just making this def_bool y. > > I think that's best. The SBI's EARLY_PRINTK support is quite clean, so I don't > see any reason to disable it. How does this look? LGTM. cheers > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > index 366f5f2cf106..cc274bbc29a7 100644 > --- a/arch/riscv/Kconfig > +++ b/arch/riscv/Kconfig > @@ -268,18 +268,7 @@ config CMDLINE_OVERRIDE > If you don't know what to do here, say N. > > config EARLY_PRINTK > - bool "Early printk" > - default n > - help > - This option enables special console drivers which allow the kernel > - to print messages very early in the bootup process. > - > - This is useful for kernel debugging when your machine crashes very > - early before the console code is initialized. For normal operation > - it is not recommended because it looks ugly and doesn't cooperate > - with klogd/syslogd or the X server. You should normally N here, > - unless you want to debug such a crash. > - > + def_bool y > > source "lib/Kconfig.debug"