From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755348AbdGKGVN (ORCPT <rfc822;w@1wt.eu>);
        Tue, 11 Jul 2017 02:21:13 -0400
Received: from ozlabs.org ([103.22.144.67]:56729 "EHLO ozlabs.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1755291AbdGKGVN (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 11 Jul 2017 02:21:13 -0400
From: Michael Ellerman <mpe@ellerman.id.au>
To: Palmer Dabbelt <palmer@dabbelt.com>, yamada.masahiro@socionext.com,
        mmarek@suse.com, will.deacon@arm.com, peterz@infradead.org,
        boqun.feng@gmail.com, mingo@redhat.com, daniel.lezcano@linaro.org,
        tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com,
        gregkh@linuxfoundation.org, jslaby@suse.com, davem@davemloft.net,
        mchehab@kernel.org, sfr@canb.auug.org.au, fweisbec@gmail.com,
        viro@zeniv.linux.org.uk, mcgrof@kernel.org, dledford@redhat.com,
        bart.vanassche@sandisk.com, sstabellini@kernel.org,
        daniel.vetter@ffwll.ch, msalter@redhat.com, nicolas.dichtel@6wind.com,
        james.hogan@imgtec.com, paul.gortmaker@windriver.com,
        linux@roeck-us.net, heiko.carstens@de.ibm.com, schwidefsky@de.ibm.com,
        linux-kernel@vger.kernel.org, patches@groups.riscv.org,
        akpm@linux-foundation.org
Cc: albert@sifive.com, Palmer Dabbelt <palmer@dabbelt.com>
Subject: Re: [PATCH 08/17] tty: New RISC-V SBI console driver
In-Reply-To: <20170711013924.22085-9-palmer@dabbelt.com>
References: <20170711013924.22085-1-palmer@dabbelt.com> <20170711013924.22085-9-palmer@dabbelt.com>
User-Agent: Notmuch/0.21 (https://notmuchmail.org)
Date: Tue, 11 Jul 2017 16:21:07 +1000
Message-ID: <87mv8b7auk.fsf@concordia.ellerman.id.au>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Palmer Dabbelt <palmer@dabbelt.com> writes:
>
...
> +#ifdef CONFIG_EARLY_PRINTK
> +static void sbi_console_write(struct console *co, const char *buf,
> +			      unsigned int n)
> +{
> +	int i;
> +
> +	for (i = 0; i < n; ++i) {
> +		if (buf[i] == '\n')
> +			sbi_console_putchar('\r');
> +		sbi_console_putchar(buf[i]);
> +	}
> +}
> +
> +static struct console early_console_dev __initdata = {
> +	.name	= "early",
> +	.write	= sbi_console_write,
> +	.flags	= CON_PRINTBUFFER | CON_BOOT,

AFAICS you could add CON_ANYTIME here, which would mean this console
would print output before the CPU is online.

I think it doesn't currently matter because you call parse_early_param()
from setup_arch(), at which point the boot CPU has been marked online.

But if this console can actually work earlier then you might be better
off just registering it unconditionally very early.

cheers

> +static int __init setup_early_printk(char *str)
> +{
> +	if (early_console == NULL) {
> +		early_console = &early_console_dev;
> +		register_console(early_console);
> +	}
> +	return 0;
> +}
> +early_param("earlyprintk", setup_early_printk);
> +#endif
> -- 
> 2.13.0