From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753613AbbKWJga (ORCPT ); Mon, 23 Nov 2015 04:36:30 -0500 Received: from mail-lf0-f50.google.com ([209.85.215.50]:34454 "EHLO mail-lf0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752804AbbKWJg2 convert rfc822-to-8bit (ORCPT ); Mon, 23 Nov 2015 04:36:28 -0500 From: Rasmus Villemoes To: Andy Shevchenko Cc: Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 6/7] test_hexdump: test all possible group sizes for overflow Organization: D03 References: <1447259718-19647-1-git-send-email-andriy.shevchenko@linux.intel.com> <1447259718-19647-7-git-send-email-andriy.shevchenko@linux.intel.com> <87h9kis3co.fsf@rasmusvillemoes.dk> <1448037839.31665.172.camel@linux.intel.com> X-Hashcash: 1:20:151123:andriy.shevchenko@linux.intel.com::3ATi7cgSSGSFPCOB:00000000000000000000000000001wgx X-Hashcash: 1:20:151123:linux-kernel@vger.kernel.org::uCJja1xIaI2EBh+q:00000000000000000000000000000000051Hm X-Hashcash: 1:20:151123:akpm@linux-foundation.org::xljLrlvCNJ6Imlq7:0000000000000000000000000000000000005o+f Date: Mon, 23 Nov 2015 10:36:25 +0100 In-Reply-To: <1448037839.31665.172.camel@linux.intel.com> (Andy Shevchenko's message of "Fri, 20 Nov 2015 18:43:59 +0200") Message-ID: <87mvu5ys4m.fsf@rasmusvillemoes.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 20 2015, Andy Shevchenko wrote: > On Thu, 2015-11-19 at 11:14 +0100, Rasmus Villemoes wrote: >> >> aren't you missing a >> >>   test_hexdump_overflow(buflen, rounddown(len, gs), 32, gs, ascii); >> >> here to also exercise the rowsize==32 code? > > I could add that as well, though it seems minor since the idea is to go > for all branches, which 16 covers anyway. Well, I didn't look into the implementation when I wrote that; it just seemed like an obvious thing to check all allowed combinations of rowsize, groupsize and ascii. >>  static int __init test_hexdump_init(void) >> >  { >> >   unsigned int i; >> > @@ -186,10 +199,10 @@ static int __init test_hexdump_init(void) >> >   test_hexdump_set(rowsize, true); >> >   >> >   for (i = 0; i <= TEST_HEXDUMP_BUF_SIZE; i++) >> > - test_hexdump_overflow(i, false); >> > + test_hexdump_overflow_set(i, false); >> >   >> >   for (i = 0; i <= TEST_HEXDUMP_BUF_SIZE; i++) >> > - test_hexdump_overflow(i, true); >> > + test_hexdump_overflow_set(i, true); >> >> It seems neater to do one loop: >> >> for (i = 0; i <= TEST_HEXDUMP_BUF_SIZE; i++) { >>   test_hexdump_overflow_set(i, false); >>   test_hexdump_overflow_set(i, true); >> } > > I would like to keep them separately, though I'm also okay to do it in > one loop. Your code, your call. Rasmus