From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753725AbbIXTos (ORCPT ); Thu, 24 Sep 2015 15:44:48 -0400 Received: from smtp01.smtpout.orange.fr ([80.12.242.123]:19814 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753629AbbIXTop (ORCPT ); Thu, 24 Sep 2015 15:44:45 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Thu, 24 Sep 2015 21:44:40 +0200 X-ME-IP: 109.222.127.209 From: Robert Jarzmik To: Vinod Koul Cc: Daniel Mack , Haojian Zhuang , linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann , Olof Johansson , Kevin Hilman Subject: Re: [PATCH] dmaengine: pxa_dma: fix initial list move References: <1442826392-9082-1-git-send-email-robert.jarzmik@free.fr> <20150924172808.GE2381@localhost> X-URL: http://belgarath.falguerolles.org/ Date: Thu, 24 Sep 2015 21:39:32 +0200 In-Reply-To: <20150924172808.GE2381@localhost> (Vinod Koul's message of "Thu, 24 Sep 2015 22:58:08 +0530") Message-ID: <87mvwbppxn.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Vinod Koul writes: > On Mon, Sep 21, 2015 at 11:06:32AM +0200, Robert Jarzmik wrote: >> Since the commit to have an allocated list of virtual descriptors was >> reverted, the pxa_dma driver is broken, as it assumes the descriptor is >> placed on the allocated list upon allocation. >> >> Fix the issue in pxa_dma by making an allocated virtual descriptor a >> singleton. > > This seems okay, simpler and safer. Do you want me to apply this instead > while detailed approach can be reviewed and discussed Yes, please. Having the guarantee this gets into the next or next after next -rc will enable me to do my pull request, and repair pxa. Cheers. -- Robert