From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932628AbbELMNe (ORCPT ); Tue, 12 May 2015 08:13:34 -0400 Received: from mail-lb0-f176.google.com ([209.85.217.176]:34854 "EHLO mail-lb0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932556AbbELMN2 (ORCPT ); Tue, 12 May 2015 08:13:28 -0400 From: Rasmus Villemoes To: Alexander Viro Cc: Boaz Harrosh , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, linux-ntfs-dev@lists.sourceforge.net, linux-kernel@vger.kernel.org, codalist@TELEMANN.coda.cs.cmu.edu, linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org Subject: Re: [Jfs-discussion] [PATCH] fs: cleanup slight list_entry abuse Organization: D03 References: <1426764485-13637-1-git-send-email-linux@rasmusvillemoes.dk> <550AF51C.9000600@plexistor.com> <550AFF79.1030105@oracle.com> X-Hashcash: 1:20:150512:codalist@telemann.coda.cs.cmu.edu::VWdbrAyp8k5tXY/R:00000000000000000000000000000Mjh X-Hashcash: 1:20:150512:linux-kernel@vger.kernel.org::IR7vm0ZAuOsXxstd:0000000000000000000000000000000000TGr X-Hashcash: 1:20:150512:jfs-discussion@lists.sourceforge.net::zkc7s3r45t+I7Wdb:00000000000000000000000001BaB X-Hashcash: 1:20:150512:linux-fsdevel@vger.kernel.org::rLLNiBydCH+M+krL:0000000000000000000000000000000014TX X-Hashcash: 1:20:150512:linux-mtd@lists.infradead.org::Hqb2G6nGZuqxR4HK:000000000000000000000000000000001QSo X-Hashcash: 1:20:150512:boaz@plexistor.com::OVQ9LsR4UCs3wCM4:00000000000000000000000000000000000000000001VCU X-Hashcash: 1:20:150512:dave.kleikamp@oracle.com::qnq1NlFlfwB3Zdao:00000000000000000000000000000000000004MhK X-Hashcash: 1:20:150512:viro@zeniv.linux.org.uk::f4eUkHACqjlNWNua:000000000000000000000000000000000000003uj/ X-Hashcash: 1:20:150512:linux-ntfs-dev@lists.sourceforge.net::B+yDgHIhpIodB64Q:00000000000000000000000005qwJ Date: Tue, 12 May 2015 14:13:25 +0200 In-Reply-To: <550AFF79.1030105@oracle.com> (Dave Kleikamp's message of "Thu, 19 Mar 2015 11:55:21 -0500") Message-ID: <87mw1a6lju.fsf@rasmusvillemoes.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 19 2015, Dave Kleikamp wrote: > On 03/19/2015 11:11 AM, Boaz Harrosh wrote: >> On 03/19/2015 01:28 PM, Rasmus Villemoes wrote: >>> list_entry is just a wrapper for container_of, but it is arguably >>> wrong (and slightly confusing) to use it when the pointed-to struct >>> member is not a struct list_head. Use container_of directly instead. >>> >>> Signed-off-by: Rasmus Villemoes >>> --- >>> Most of these predate git. If I'm the only one who has been confused >>> by this in 10 years, maybe it's not worth the churn. >>> >> >> No you are not alone here. I have seen this once as well but did not have >> the gumption to send a fix. (The sysv.h one) >> >> I totally agree with this patch. (So many of them, bread crumbs of copy/paste >> for you ;0) > > I'm sure that was the case with jfs. > >> >> Reviewed-by: Boaz Harrosh > > Acked-by: Dave Kleikamp Al, any chance you'd take this through the vfs tree? Rasmus