mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Don Zickus <dzickus@redhat.com>,
	acme@ghostprotocols.net, LKML <linux-kernel@vger.kernel.org>,
	jmario@redhat.com, fowles@inreach.com, bp@alien8.de
Subject: Re: [PATCH 1/4] perf: Allow ability to map cpus to nodes easily
Date: Mon, 07 Apr 2014 14:28:35 +0900	[thread overview]
Message-ID: <87mwfxyags.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <20140406121546.GC1164@krava.brq.redhat.com> (Jiri Olsa's message of "Sun, 6 Apr 2014 14:15:46 +0200")

On Sun, 6 Apr 2014 14:15:46 +0200, Jiri Olsa wrote:
> On Thu, Apr 03, 2014 at 02:48:51PM +0900, Namhyung Kim wrote:
>> More generally, this sysfs access needs to check actual mountpoint using
>> sysfs__mountpoint() IMHO.
>> 
>> Also this API can be generalized like reading int value from a sysfs
>> file as the filename itself represents the content in most cases.
>> 
>> So how about changing this way?  It might reside on somewhere in tools/lib/api/fs/.
>> 
>>   max_cpu_num = sysfs__read_int("devices/system/cpu/possible");
>> 
>>   max_node_num = sysfs__read_int("devices/system/node/possible");
>> 
>> 
>> Hmm.. looking at the code, perf already has filename__read_{int,str} API
>> in util/util.c.  Maybe you can just use it instead.
>
> I think those just read the file, while Don needs to parse
> the map to get max cpu number

Ah, missed that... sorry for noise.

Thanks,
Namhyung

  reply	other threads:[~2014-04-07  5:28 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-24 19:32 [PATCH 0/4] perf: Make some functions generic Don Zickus
2014-03-24 19:32 ` [PATCH 1/4] perf: Allow ability to map cpus to nodes easily Don Zickus
2014-03-29 17:10   ` Jiri Olsa
2014-04-01  2:39     ` Don Zickus
2014-04-06 12:19       ` Jiri Olsa
2014-04-03  5:48   ` Namhyung Kim
2014-04-06 12:15     ` Jiri Olsa
2014-04-07  5:28       ` Namhyung Kim [this message]
2014-04-07 18:20         ` Don Zickus
2014-03-24 19:32 ` [PATCH 2/4] perf, kmem: Utilize the new generic cpunode_map Don Zickus
2014-03-29 17:10   ` Jiri Olsa
2014-04-01  2:42     ` Don Zickus
2014-04-06 12:21       ` Jiri Olsa
2014-04-07 18:18         ` Don Zickus
2014-03-24 19:32 ` [PATCH 3/4] perf, callchain: Add generic report parse callchain callback function Don Zickus
2014-03-29 17:11   ` Jiri Olsa
2014-04-03  5:57   ` Namhyung Kim
2014-04-04 19:31     ` Don Zickus
2014-04-06 12:11       ` Jiri Olsa
2014-04-07  5:15         ` Namhyung Kim
2014-04-07  7:01           ` Jiri Olsa
2014-03-24 19:32 ` [PATCH 4/4] perf, report: Use new generic report parse callchain callback Don Zickus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mwfxyags.fsf@sejong.aot.lge.com \
    --to=namhyung@kernel.org \
    --cc=acme@ghostprotocols.net \
    --cc=bp@alien8.de \
    --cc=dzickus@redhat.com \
    --cc=fowles@inreach.com \
    --cc=jmario@redhat.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome