mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: "Liu\, Chuansheng" <chuansheng.liu@intel.com>
Cc: "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mmc\@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	"Yanmin Zhang \<yanmin_zhang\@linux.intel.com\>
	\(yanmin_zhang\@linux.intel.com\)" <yanmin_zhang@linux.intel.com>
Subject: Re: [PATCH] sdio: Change pr_warning to pr_warn_ratelimited
Date: Mon, 09 Jul 2012 06:29:52 -0400	[thread overview]
Message-ID: <87mx39ut0f.fsf@octavius.laptop.org> (raw)
In-Reply-To: <27240C0AC20F114CBF8149A2696CBE4A0DD517@SHSMSX101.ccr.corp.intel.com> (Chuansheng Liu's message of "Thu, 14 Jun 2012 10:49:17 +0000")

Hi,

On Thu, Jun 14 2012, Liu, Chuansheng wrote:
> From: liu chuansheng <chuansheng.liu@intel.com>
> Subject: [PATCH] sdio: Change pr_warning to pr_warn_ratelimited
>
> When debug one bad issue, got lots of pr_warning messages
> "queuing unknown CIS tuple" which caused the printk storm
> and flooded the console.
>
> This patch is changing the pr_warning api to pr_warn_ratelimited.
>
> Signed-off-by: liu chuansheng <chuansheng.liu@intel.com>
> ---
>  drivers/mmc/core/sdio_cis.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/core/sdio_cis.c b/drivers/mmc/core/sdio_cis.c
> index f1c7ed8..8e94e55 100644
> --- a/drivers/mmc/core/sdio_cis.c
> +++ b/drivers/mmc/core/sdio_cis.c
> @@ -313,7 +313,7 @@ static int sdio_read_cis(struct mmc_card *card, struct sdio_func *func)
>  
>                         if (ret == -ENOENT) {
>                                 /* warn about unknown tuples */
> -                               pr_warning("%s: queuing unknown"
> +                               pr_warn_ratelimited("%s: queuing unknown"
>                                        " CIS tuple 0x%02x (%u bytes)\n",
>                                        mmc_hostname(card->host),
>                                        tpl_code, tpl_link);

Thanks, pushed to mmc-next for 3.6.

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

      reply	other threads:[~2012-07-09 10:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-14 10:49 Liu, Chuansheng
2012-07-09 10:29 ` Chris Ball [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mx39ut0f.fsf@octavius.laptop.org \
    --to=cjb@laptop.org \
    --cc=chuansheng.liu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=yanmin_zhang@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome