mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung.kim@lge.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
	Ingo Molnar <mingo@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing: Check return value of tracing_dentry_percpu()
Date: Tue, 15 May 2012 17:41:01 +0900	[thread overview]
Message-ID: <87mx59zvj6.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <1335143517-2285-1-git-send-email-namhyung.kim@lge.com> (Namhyung Kim's message of "Mon, 23 Apr 2012 10:11:57 +0900")

Hi, Steve.

Can you have a look at this?

Thanks,
Namhyung

On Mon, 23 Apr 2012 10:11:57 +0900, Namhyung Kim wrote:
> If tracing_dentry_percpu() failed, tracing_init_debugfs_percpu()
> will try to create each cpu directories on debugfs' root directory
> as d_percpu is NULL.
>
> Signed-off-by: Namhyung Kim <namhyung.kim@lge.com>
> ---
>  kernel/trace/trace.c |    3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index ed7b5d1e12f4..54df9a672fd9 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -4367,6 +4367,9 @@ static void tracing_init_debugfs_percpu(long cpu)
>  	struct dentry *d_cpu;
>  	char cpu_dir[30]; /* 30 characters should be more than enough */
>  
> +	if (!d_percpu)
> +		return;
> +
>  	snprintf(cpu_dir, 30, "cpu%ld", cpu);
>  	d_cpu = debugfs_create_dir(cpu_dir, d_percpu);
>  	if (!d_cpu) {

  reply	other threads:[~2012-05-15  8:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-23  1:11 Namhyung Kim
2012-05-15  8:41 ` Namhyung Kim [this message]
2012-05-19 10:20 ` [tip:perf/core] " tip-bot for Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mx59zvj6.fsf@sejong.aot.lge.com \
    --to=namhyung.kim@lge.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome