From: Peter Korsgaard <jacmet@sunsite.dk>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: dbrownell@users.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mcp23s08: support mcp23s17 variant
Date: Tue, 15 Feb 2011 13:47:04 +0100 [thread overview]
Message-ID: <87mxlxa2if.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <AANLkTikri_A1VknD3oLR2LwC4ysOgE20RnqMRdYnHbcP@mail.gmail.com> (Grant Likely's message of "Mon, 14 Feb 2011 11:59:16 -0700")
>>>>> "Grant" == Grant Likely <grant.likely@secretlab.ca> writes:
Hi,
>> We could. I didn't do it because the 8bit and 16bit cases are very
>> similar, and checking a simple integer is presumably a lot faster than
>> the spi access - But I can rework the patch if you insists.
Grant> I won't insist, but it really does look like something that should
Grant> have separate accessors from a code maintenance perspective.
Ok, I've just respun the patch with seperate accessors.
>> I wouldn't call it unrelated. It's to ensure it still lines up after the
>> s/u8/unsigned/.
Grant> Sorry, you're right. I missed the s/u8/unsigned/ change. I don't
Grant> have any problem with whitespace changes in a hunk that is also
Grant> getting a real change.
Ok, good.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2011-02-15 12:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-14 16:12 Peter Korsgaard
2011-02-14 17:13 ` Grant Likely
2011-02-14 18:29 ` Peter Korsgaard
2011-02-14 18:59 ` Grant Likely
2011-02-15 12:47 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mxlxa2if.fsf@macbook.be.48ers.dk \
--to=jacmet@sunsite.dk \
--cc=dbrownell@users.sourceforge.net \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome