mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Roland McGrath <roland@redhat.com>
Cc: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] notify_parent and ptrace cleanup
Date: Sat, 21 Aug 2004 20:47:55 +0900	[thread overview]
Message-ID: <87n00o3e6s.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <200408210109.i7L19Kjf006151@magilla.sf.frob.com>

Roland McGrath <roland@redhat.com> writes:

> +	spin_unlock_irq(&current->sighand->siglock);

This unlock is odd. lock is missing?

> +	read_lock(&tasklist_lock);
> +	do_notify_parent_cldstop(current, current->parent);
> +	read_unlock(&tasklist_lock);
> +	schedule();
> +
> +	/* We are back.  */
> +	current->last_siginfo = NULL;
> +}

->last_siginfo is racy. Please, really please don't extend it until
the race condition is fixed.

SIGCONT restart the stopped task. Any lock doesn't prevent it.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

  reply	other threads:[~2004-08-21 11:48 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-18  0:40 [PATCH] notify_parent cleanup Roland McGrath
2004-08-18  6:44 ` Andrew Morton
2004-08-21  1:09   ` [PATCH] notify_parent and ptrace cleanup Roland McGrath
2004-08-21 11:47     ` OGAWA Hirofumi [this message]
2004-08-25  2:43       ` Roland McGrath
2004-08-25 17:51         ` OGAWA Hirofumi
2004-08-25 18:08           ` Roland McGrath
2004-08-25 19:48             ` OGAWA Hirofumi
2004-08-25 19:54               ` Linus Torvalds
2004-08-25 20:20                 ` Roland McGrath
2004-08-25 20:53                   ` OGAWA Hirofumi
2004-08-25 21:02                     ` Linus Torvalds
2004-08-25 21:07                       ` Roland McGrath
2004-08-25 21:45                         ` OGAWA Hirofumi
2004-08-19  4:26 ` [PATCH] notify_parent cleanup OGAWA Hirofumi
2004-08-19 20:59   ` Roland McGrath
2004-08-19 22:01     ` OGAWA Hirofumi
2004-08-19 22:04       ` Roland McGrath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87n00o3e6s.fsf@devron.myhome.or.jp \
    --to=hirofumi@mail.parknet.co.jp \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roland@redhat.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome