Re: [PATCH 08/13] ALSA: hda: Discard pm_runtime_put_autosuspend() return value

[Takashi Iwai <tiwai@suse.de>]

On Wed, 07 Oct 2026 01:13:36 +0200,
Brian Norris wrote:
> 
> snd_hdac_power_down() and snd_hdac_power_down_pm() are defined to return
> an int, but their return values are never used by any caller.
> snd_hdac_power_down() also passes the return value of
> pm_runtime_put_autosuspend() to the caller, which is not very useful.
> 
> Returning an error code from pm_runtime_put_autosuspend() merely means
> that it has not queued up a timer or work item to check whether or not
> the device can be suspended and there are many perfectly valid
> situations in which that can happen, like after writing "on" to the
> device's runtime PM "control" attribute in sysfs for one example.
> 
> Modify snd_hdac_power_down() to discard the pm_runtime_put_autosuspend()
> return value and change the return types of snd_hdac_power_down() and
> snd_hdac_power_down_pm() to void.
> 
> No intentional functional impact.
> 
> This will facilitate a planned change of the
> pm_runtime_put_autosuspend() return type to void in the future, similar
> to commit 3afd8df02433 ("PM: runtime: Change pm_runtime_put() return
> type to void").
> 
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> ---
> This patch is independent of the rest of the series, except for the end
> (changing the return type). I expect it can be applied by individual
> maintainers, and we pick up the end once the dust is settled.

OK, I applied this one to sound.git tree for-next branch now.


thanks,

Takashi