From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D680541A794 for ; Wed, 12 Aug 2026 10:02:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786528949; cv=none; b=WcU9LdL/uZ7dOcsza6NWxuUWI1Mx0vJJAQZjdzjT4nght+QAJx8HREqwoykW2XKuLutOvGjBoOpVwIB96L9wGsG9W0rdPxvBGApwPpgOW6TLKEJ29FvkywiOioh6oezdPzLXjbFPSxO2lpBcwkoeGqC2hsAjPQdChSZtnLb0aGk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786528949; c=relaxed/simple; bh=cNiBZHt9kBQLY9Pvle7ghRA8gmUmPsgLNZWvyn6d4Fs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=rtXb/MkLTeZRQku/dy0m2kvl/LkvrtZEWaRl8s11DzG7qD2FjajsaU/sVKjyA77IepSyoZKPObsnlGHT5epEsilqyWDyojabFE9hBTEXj6XrLRmUJDn162Qb1dh1q6jEAtlPfY8dqQQ+fJw0yQ+N4xpjfyKI0OKrQoJoz99fI8s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=QXeQ/l3r; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="QXeQ/l3r" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 294D81A15AC; Wed, 12 Aug 2026 10:02:23 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id EADC86045E; Wed, 12 Aug 2026 10:02:22 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 7A96911C4CBBE; Wed, 12 Aug 2026 12:02:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1786528941; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=cNiBZHt9kBQLY9Pvle7ghRA8gmUmPsgLNZWvyn6d4Fs=; b=QXeQ/l3rqQbZPi2SFx690Mf7wrlgCIPYcIzVTdm3x3N+LR0BunqRKE5/PkPJn5ah3iZTSz dqOG8NFj3QbWExuVHA2nzkfO7+3lgsePMv+oUldVz6Coj/eeFerkg19VbYVbYvAQNj1MxP f5/jwsokmbtVEgABox4TNTWbVVJfQO7RgI4K7HspEFuC0ZIEh4q9JamTqkpfbWwsg3Q0Lp MnIpt/ypg+eN+otJRt5TgYjcxJvsvMa93PQCH3OFjuqjzKOBBowHoe+u0/MDZWZCPMX95F 9A07l+e1mhP3RAKuB385fyN50g/1YvVoiruTKBiCf6RAC61GAxU8i1wLhN2wBA== From: Miquel Raynal To: Tudor Ambarus Cc: Pratyush Yadav , Michael Walle , Takahiro Kuwano , Richard Weinberger , Vignesh Raghavendra , Thomas Petazzoni , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] mtd: spi-nor: Unprepare legacy controllers upon RWW wait interruption In-Reply-To: (Tudor Ambarus's message of "Wed, 12 Aug 2026 12:52:48 +0300") References: <20260811-perso-rww-fixes-v1-1-5866a70e5d1c@bootlin.com> User-Agent: mu4e 1.12.12; emacs 30.2 Date: Wed, 12 Aug 2026 12:02:17 +0200 Message-ID: <87o6f7mzbq.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 On 12/08/2026 at 12:52:48 +03, Tudor Ambarus wro= te: > On 8/11/26 6:56 PM, Miquel Raynal wrote: >> All the parallel locking helpers (spi_nor_prep_and_lock(), >> spi_nor_prep_and_lock_pe() and spi_nor_prep_and_lock_rd()) call >> spi_nor_prep() then wait with a killable sleep. If the sleep gets >> killed, we leave the controller in its prepared state. >>=20 >> Call ->unprepare() in these cases. > > > We don't even care about SPI NOR controllers. I stopped adding/accepting > new support for them few years ago, so that we encourage people to update > the drivers to use SPI MEM. Yeah, totally agreed. > The alternative is to drop prep unprep entirely. That's indeed what we aim for, but in order to "fix" that report, the current solution is to call ->unprepare(). Hopefully we can remove them at some point. > > Anyway, all good, regardless the path chosen: > > Acked-by: Tudor Ambarus Thanks, Miqu=C3=A8l