From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D7223955D0 for ; Wed, 10 Jun 2026 07:49:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781077743; cv=none; b=uikNBNCELGZwcPtryF111U0rQXoz+GV0qUXD1dFd0/0+iDXX4WP4AJ8MOsd4xyWoVJkW6KlKwz+XzDMjUb3bxfjxGyxNYIBEe03Oe/SUyPjCRuTmafe9OpHWjqeZUsVLYBfQ3xkr0R4Pzw4ecgLuxRdDSE3myWmGLbHnYcV9Dv0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781077743; c=relaxed/simple; bh=YhnipDLGg3txWkfssVNvTnwATli4QFRD9WJtStTrNZc=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=LbHeBATCWU9Iu8hartAw5Wl82nBsT5Uzmfav9pqQ5Gq24XwYAUlOKZfgCHy4ZCuQhNcMw0M5tj42DIBXzcP104Q2oQTt5V7VBbXdujqrQBzCAhK5yw72d4VtWfniIoS5G/cbRU7EX25dCxA7CWQgBaFR9Qa4mjgqJuw9OplDn/s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=pPbEinat; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=PoCD93VJ; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=pPbEinat; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=PoCD93VJ; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="pPbEinat"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="PoCD93VJ"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="pPbEinat"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="PoCD93VJ" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B42067592E; Wed, 10 Jun 2026 07:48:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1781077738; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P4qMWAMgpHX0VP63DRLudNmWXCYjd3QviDNx0L0I6aw=; b=pPbEinatxlD42gWR5OBhcs8cM+uGLpD3OWdZCVnTBgpFQS5dKBo69/09YU6oHrMLRs+cQk Wz11WI4hLXaD650BbitkH9RESZ14aFF9VuuLeQcdExvaclke3kuRKKAsYiOUD0e0xKQfhP s2//iTlhngsV8HDNpyeJcOZ/lxAcmjw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1781077738; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P4qMWAMgpHX0VP63DRLudNmWXCYjd3QviDNx0L0I6aw=; b=PoCD93VJBG6ZO8/8glUc4iHSanJHTL6ZOAlkVdKi2YUQZ2pwbB6CEKMoxxg8Oe+dDaPnuq J609dGQVw/I8H/Dw== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=pPbEinat; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=PoCD93VJ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1781077738; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P4qMWAMgpHX0VP63DRLudNmWXCYjd3QviDNx0L0I6aw=; b=pPbEinatxlD42gWR5OBhcs8cM+uGLpD3OWdZCVnTBgpFQS5dKBo69/09YU6oHrMLRs+cQk Wz11WI4hLXaD650BbitkH9RESZ14aFF9VuuLeQcdExvaclke3kuRKKAsYiOUD0e0xKQfhP s2//iTlhngsV8HDNpyeJcOZ/lxAcmjw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1781077738; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P4qMWAMgpHX0VP63DRLudNmWXCYjd3QviDNx0L0I6aw=; b=PoCD93VJBG6ZO8/8glUc4iHSanJHTL6ZOAlkVdKi2YUQZ2pwbB6CEKMoxxg8Oe+dDaPnuq J609dGQVw/I8H/Dw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8C215779A7; Wed, 10 Jun 2026 07:48:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Nr7uIOoWKWqSVwAAD6G6ig (envelope-from ); Wed, 10 Jun 2026 07:48:58 +0000 Date: Wed, 10 Jun 2026 09:48:58 +0200 Message-ID: <87o6hi6djp.wl-tiwai@suse.de> From: Takashi Iwai To: Frank van de Pol Cc: perex@perex.cz, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/1] ALSA: usb: Add support for Reloop Jockey 3 DJ controllers In-Reply-To: <20260609221643.3439698-1-fvdpol@gmail.com> References: <20260609221643.3439698-1-fvdpol@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/30.2 Mule/6.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spam-Flag: NO X-Rspamd-Action: no action X-Spam-Level: X-Spamd-Result: default: False [-3.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FUZZY_RATELIMITED(0.00)[rspamd.com]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCPT_COUNT_THREE(0.00)[4]; RCVD_VIA_SMTP_AUTH(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,sashiko.dev:url,suse.de:mid,suse.de:dkim] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: B42067592E X-Spam-Score: -3.51 On Wed, 10 Jun 2026 00:16:42 +0200, Frank van de Pol wrote: > > > Hi Takashi, Hello ALSA community, > > After being away from active ALSA development for some 25 years or so, I am > happy to submit this patch to introduce a dedicated driver supporting the > Jockey 3 series of DJ Controllers made by Reloop (specifically covering the > Master Edition and the Remix variants). > > I initially evaluated the feasibility of integrating the required logic to > handle the non-standard proprietary Ploytec framing protocol into the standard > USB-audio driver via quirks. However, doing so would require introducing > numerous hardware-specific exceptions throughout the core layout, adding > significant complexity. A clean, isolated driver subdirectory provides much > better long-term maintainability without cluttering the existing class-compliant > architecture. > > I have successfully validated and stress-tested this driver across three > distinct hardware architectures to ensure robustness regarding DMA, timing, > and memory alignment: > - x86_64 (Standard PC desktop environment) > - armhf (32-bit legacy environment on a Raspberry Pi 1B) > - arm64 (64-bit modern SoC environment on a Raspberry Pi 4) > > I look forward to your review and feedback, and I am more than happy to > make architectural adjustments as required. > > Best regards, > Frank van de Pol Hi Frank, nice to hear you again! Through a quick glance, the driver design looks good and most of the code are fine, but there can be small details that matter. Could you take a look at Sashiko review? https://sashiko.dev/#/patchset/20260609221643.3439698-2-fvdpol%40gmail.com Not all items pointed there are useful, but the playback/capture stream spinlock should be taken, and the use of the devres-memory for URB buffer needs the re-consideration, too. Last but not least, for the resubmission, please send to linux-sound@vger.kernel.org (and Cc to linux-kernel@vger.kernel.org). Recently we use alsa-devel ML only for user-space stuff, and the kernel patches go to vger. thanks, Takashi