mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Denis Batishchev <ii343hbka@gmail.com>
Cc: Takashi Iwai <tiwai@suse.de>,
	perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Enable micmute LED on HP EliteBook 6 G1a
Date: Fri, 05 Jun 2026 08:21:27 +0200	[thread overview]
Message-ID: <87o6hpv76g.wl-tiwai@suse.de> (raw)
In-Reply-To: <CA+W-NrXBVkm6bvTT8+Ri=1y11A0zBK7fFVmb5m_nKHjTu9O51g@mail.gmail.com>

On Thu, 04 Jun 2026 21:52:41 +0200,
Denis Batishchev wrote:
> 
> 
> This patch fixes the mic-mute led at HP Elitebook 6 g1a.

Ah, so you mean there is another LED for the audio-mute and it's not
covered by this patch?  Please make the description a bit more
clearer.


thanks,

Takashi


> On Thu, Jun 4, 2026, 17:23 Takashi Iwai <tiwai@suse.de> wrote:
> 
>     On Thu, 04 Jun 2026 15:15:18 +0200,
>     Denis Batishchev wrote:
>     >
>     > The HP EliteBook 6 G1a (SSID 103c:8e0d) uses a Realtek ALC236 codec.
>     > Without a quirk no fixup is selected and the mic-mute LED stays off.
>     > It needs the same ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF quirk as the
>     > already-supported 14" variant (SSID 103c:8dfb), so add it.
>     >
>     > Note: I don't know how to fix sound-mute LED though.
>    
>     What does this mean?  Is this patch confirmed to work or not?
>    
>     > Signed-off-by: Denis Batishchev <ii343hbka@gmail.com>
>     > Cc: <stable@vger.kernel.org>
>     > ---
>     >  sound/hda/codecs/realtek/alc269.c | 1 +
>     >  1 file changed, 1 insertion(+)
>     >
>     > diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/
>     realtek/alc269.c
>     > index 78a865709..8eebf9159 100644
>     > --- a/sound/hda/codecs/realtek/alc269.c
>     > +++ b/sound/hda/codecs/realtek/alc269.c
>     > @@ -7274,6 +7274,7 @@ static const struct hda_quirk alc269_fixup_tbl[] =
>     {
>     >       SND_PCI_QUIRK(0x103c, 0x8df1, "HP EliteBook 630 G12",
>     ALC236_FIXUP_HP_GPIO_LED),
>     >       SND_PCI_QUIRK(0x103c, 0x8df7, "HP Z66 G6",
>     ALC236_FIXUP_HP_GPIO_LED),
>     >       SND_PCI_QUIRK(0x103c, 0x8dfb, "HP EliteBook 6 G1a 14",
>     ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
>     > +     SND_PCI_QUIRK(0x103c, 0x8e0d, "HP EliteBook 6 G1a 14",
>     ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
>     >       SND_PCI_QUIRK(0x103c, 0x8dfc, "HP EliteBook 645 G12",
>     ALC236_FIXUP_HP_GPIO_LED),
>     >       SND_PCI_QUIRK(0x103c, 0x8dfd, "HP EliteBook 6 G1a 16",
>     ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
>     >       SND_PCI_QUIRK(0x103c, 0x8dfe, "HP EliteBook 665 G12",
>     ALC236_FIXUP_HP_GPIO_LED),
>    
>     The table is sorted in PCI SSID order.  Please try to put the entry at
>     the right position.
> 
>     thanks,
>    
>     Takashi
> 
> -- Денис
> 

  parent reply	other threads:[~2026-06-05  6:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-04 13:15 Denis Batishchev
2026-06-04 15:23 ` Takashi Iwai
     [not found]   ` <CA+W-NrXBVkm6bvTT8+Ri=1y11A0zBK7fFVmb5m_nKHjTu9O51g@mail.gmail.com>
2026-06-05  6:21     ` Takashi Iwai [this message]
2026-06-09 13:56 ` [PATCH v2] " Denis Batishchev
2026-06-09 14:15   ` Geraldo Nascimento
2026-06-12 20:30     ` Denis Batishchev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o6hpv76g.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=ii343hbka@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=stable@vger.kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome