From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C52283EF0A7 for ; Fri, 15 May 2026 09:35:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778837751; cv=none; b=Eb0TkHwuI8JtSeovcHKeNmuylGOJ5EQJsfxN1cNN4isa1ImzWb+R/BlFHsfXxtzOydKFsnub9Uqzv1CXJekDgw8KeWeIHtDlSRdB9inI053f/uzfc+VId79hgHVv4KX2cRreGn6AXm/MoWLXfhyDF837lw/kqtKrlIy6pIg8ejk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778837751; c=relaxed/simple; bh=4FXsnFGmockbzHjYaQrA1CAXkTJm+gIyqYeFTX+kiyI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=rRXkA5zmWdaY26wo5ZtedEcU6SzQdZ5Leo92VJF6/WL/d1FfXShloEdYiXwtKT+ImRO66l3c4vGFOu8yt2Zr02KSMzR+5ntyKym+My8VdICJBzAGllm538aGZCgxVgtJEN/0XVQRFRg/4EKq7FqQuo9nO+/Z9P2TXUFPZmysR0c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Yj6q1sHN; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=dbtD+vYv; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Yj6q1sHN"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="dbtD+vYv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778837748; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tK4K+HoEFodeqj4ZSnIg/mlD1eHHL0CKGkFwFzadqEc=; b=Yj6q1sHNvYplLJ1ihYH/aOM0M7WTazUuBdBqwgbCwcZ2heYPO9ZkPVggeZRlwHa6offOM5 nAOmrPleUGKKyYgy33jMGf/Q+RG08yXuV1auc6uTl3sWO3rlTx+GaN9NAK2bhqeOskfcMl Z45SzNSCBxIw5NXNY0FsQxZBndb6OTU= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-422-E_WzQMocPGuHOjtrAQ5ZPg-1; Fri, 15 May 2026 05:35:47 -0400 X-MC-Unique: E_WzQMocPGuHOjtrAQ5ZPg-1 X-Mimecast-MFC-AGG-ID: E_WzQMocPGuHOjtrAQ5ZPg_1778837746 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-44b186b715aso5574661f8f.0 for ; Fri, 15 May 2026 02:35:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1778837746; x=1779442546; darn=vger.kernel.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=tK4K+HoEFodeqj4ZSnIg/mlD1eHHL0CKGkFwFzadqEc=; b=dbtD+vYvWzV3FqG6xdFgzV/KgX7SAaGFpSYzJUyq+SKeNG313zLwkQmjeQcJWvHhf1 bNL5St8cEJjHK75DOMGPOX37ztP2doxloWSfbC3UuWtvQFFFS5fWe39jxEuHFMFaYGys MXA4L/6lUu1gLR5Sgl/ap0mSmQHYLf2C8wakngnXJ1kIlsdWuaha1hvwWu11G2qnagwE zrEPI0JkZrH8KWMa5c0GCkM5WWfealWn3zs5ouwQR/WNUPTd3/6LkSwuLNpQILjdkVVa B5+uPA9h3tBjsX84EMvYFBC+JmRZ9yB62To0s3sMx6gUfTxC8HsK1ouIz35hwQLaoLOn TTrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778837746; x=1779442546; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tK4K+HoEFodeqj4ZSnIg/mlD1eHHL0CKGkFwFzadqEc=; b=SBwFvJK3qUpKSiN85OhELq7nkDfK3mz9DK+Xfp+Jtq6JVHNnM4/AYQs1FhjEZfm0vr 2v2mIMkQP+SkbRNHRVEWxIZIL5BeCvzoiaqhdZ3N37rlhMSpmXz74KqUonhXYfNyf64Z KSDcokwstc9I1xChNQNIiMMQ4qfIpYiJbyIBKvL4oIiChkUqbtltwu5GfK+ZN47YkSJb iOWj4OVUjryZdOP4mHb6WvCyOapZH2bIMcUwU2McGXIKZGw3lnQk/5qtzqSdYmk8mA3F 6L83gG5ofA1eNXllXsVSlou9CuXiOhZINRPqfiSHDIPhMoNuW1mhNrav2ceZeNrXZm6L kxTw== X-Gm-Message-State: AOJu0YxHztrBq+lnDydvmx4CRtjP6z7p4eMxffIHrw0Y1EkMciTSLjff c7S4x4ZbNtKASY4WsChXDiEK7HGO2trCACu+2vglVmQxBnuRAh1laglp2F3ww3IENdszneTLT5/ bjXu3Y1O29k1kBZ8LP1nN8iFC0pf4I3W/eqM+m52IaewNYDUTNosGAWN/4rk6zILgKA== X-Gm-Gg: Acq92OEFs0mBU2U1zchgJae9bktOwtHBgVQZqjSynA1NLGHaN89hWVn3ceppZZBuq/B GVgxAHzFOTrc6wHbtf8p3waoh4YHuvKuM9zd2kTWfIXDZCk9cma56stTAfYG9hioUen0lMriku9 8M9xFxC7nMa0iSDZfKQF4WyDaqCscNmjPeraqarP1QgpTnz5NO5XYFeht6w9kibI1VO+7miLRlw 6+MMPLpYV2g9nSIqKqjP5ABo/QOwmW0riB4wbY0QbpmvtlMEis0wi8RBp8CA4jHKY3KwdXAIkt9 WZ2SfJ0Rt7BjT+0Q/ViYhEPYQrAY8RkvEnH2ESmI0f7Xl/OjV7KO07WhOhUcqcTgSmXYYo5WmPm C2vy5D9ynkl/3w69kpT2uYfTyRazzS7CujTj/JR3pnjldvxmOUcM/0FyeSsuWJkykggYYZ2DO/U FYc+kEa5rGsWxipzI= X-Received: by 2002:a05:6000:401e:b0:43c:d665:3830 with SMTP id ffacd0b85a97d-45e5c59540bmr3873664f8f.32.1778837746003; Fri, 15 May 2026 02:35:46 -0700 (PDT) X-Received: by 2002:a05:6000:401e:b0:43c:d665:3830 with SMTP id ffacd0b85a97d-45e5c59540bmr3873596f8f.32.1778837745483; Fri, 15 May 2026 02:35:45 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da15a6454sm12934912f8f.34.2026.05.15.02.35.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2026 02:35:44 -0700 (PDT) From: Javier Martinez Canillas To: Maxime Ripard Cc: linux-kernel@vger.kernel.org, Andrzej Hajda , David Airlie , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Luca Ceresoli , Maarten Lankhorst , Neil Armstrong , Phong LE , Robert Foss , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: Re: [PATCH v4 1/3] drm/bridge: ite-it66121: Switch to the HDMI connector helpers In-Reply-To: <20260515-magnificent-boisterous-dragonfly-2560d4@houat> References: <20260515090220.809830-1-javierm@redhat.com> <20260515090220.809830-2-javierm@redhat.com> <20260515-magnificent-boisterous-dragonfly-2560d4@houat> Date: Fri, 15 May 2026 11:35:43 +0200 Message-ID: <87o6ihxbf4.fsf@ocarina.mail-host-address-is-not-set> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Maxime Ripard writes: Hello Maxime, > On Fri, May 15, 2026 at 11:02:09AM +0200, Javier Martinez Canillas wrote: [...] >> +static int it66121_bridge_hdmi_write_hdmi_infoframe(struct drm_bridge *bridge, >> + const u8 *buffer, size_t len) >> +{ >> + return 0; >> +} >> + > > When the code says it's mandatory, it means "it needs to be implemented" ;) > Fair. The driver currently is only implenting AVI infoframes, but I agree that needs to implement these too. I'll tackle that in the next iteration. > Looks good otherwise Thanks again for all your feedback and patience reviewing this series. > Maxime -- Best regards, Javier Martinez Canillas Core Platforms Red Hat