From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C67426AFC for ; Mon, 23 Dec 2024 06:54:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734936896; cv=none; b=qLJ0CazBBBj1g2TdNsKXEfr5iwCmcHNpOFzlnyqhyoK+CrP+68DrsWCZV9Y9I4OS1bOo6a1DDrfHcBdLCxYy183KtYpL1s5lm7uK7/TGeGzn+yMhvwXwolnXfJUHBXQG9NURNCZjygMr7Eo/gH1Eiab625+5FN45TmsQQRmbyOE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734936896; c=relaxed/simple; bh=d3y+7AKIAXv+wvXxjmKNl6o1SoJKLjGpWytDIKOqk0E=; h=From:To:Cc:Subject:In-Reply-To:Date:Message-ID:References: MIME-version:Content-type; b=prEr8VFsg2u3yxWlf4YQFFsT9qFV0FKb3Nxuc0KtSA31Lb9Vn6NANFt/apxqhKQfntNL8W6VbIuBGnDvJEk6ZRAoOSxxudM11bcCJULkTrvuwGaQT3YfgwyUo0fUwoIghPVbx9Sb/yKVjYF/HUpPEQRhayyhIjF5Ch8ymXYkZCI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=b3LtXLjE; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b3LtXLjE" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2162c0f6a39so43010525ad.0 for ; Sun, 22 Dec 2024 22:54:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734936894; x=1735541694; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:message-id:date :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=yv/32rgFjjNuZgsAnk/iLhxS2YZw5D1QKxhI1Z9YU6o=; b=b3LtXLjE7rBC5f6yN+hFFHH9wfCT6epesV9MViP1d9YbkpXG3FxM9/+YeLaDRHcDKh 8tV0Usw4Dm4/ToqIkVQG8Oyg/9ultYg7Q6fq7sMGUCnLBBaehQ8zfb1tRXqySX63zzjN QwKIFeiR7chsL4CWhbSqMRKDjOa4ee3god3sV3IfEEOoWNwJvScsVk+gMjWEesIZS+ih 6lIOsX3wjPfYHCya4Ksmn+1d7VcPe5IU8zKJnLJIDvg9InWDZfmQkNhetEGYhgDVRy7P ei5PsnbXDXWWNFT4ye1LRJ9go/PPhJkzVIjqnmUcS4+yHriRFljs/4oEub46VM9uMROK 03AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734936894; x=1735541694; h=content-transfer-encoding:mime-version:references:message-id:date :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yv/32rgFjjNuZgsAnk/iLhxS2YZw5D1QKxhI1Z9YU6o=; b=hT86qKuZUsOXFzxFZu6UbZBjyIjZfLBH9Z7lvVU+Fr9xXiFVPLejdG3tJEr+Vt0tll Gv44q/YTzN1Cesw3Otl0QgF5+o7QmoO3skcJa8IwqGslLC3lUOF47p+FHXE6GfJDFo1S 2rhelCgludZ83jHSkaD92PpmSvwxevURZiH4zWbea9mmq/WHpQhTZfDe4M4xeSkt3EEx uCNuxHD7L8itDBEGu66vgoHjQdPAO7n2FFZ0tpdMNfMr/JPiyHmJCao4un11rcV6My7U 8H6Z/AY8xMu665b6/6hw/cm/4+dtlTDy60ZZvcRZl/e47xm/ApfR+x6oQoh5BmvBNxCm CoVA== X-Forwarded-Encrypted: i=1; AJvYcCVqDE3hL68ftAJjMadq56piq/tRxCP9rLA3BGV5RtCDtFG0vHG5wSWmGD+ULMXAP5nzOduVmRJZzW0gCQ4=@vger.kernel.org X-Gm-Message-State: AOJu0YyyGqk1HYj/S70L+7/4/Y7SE1zPpdipyWQzBo4TvSnJB7PgU6NF XJ12166Utd/Emjr1flTmMmjy5LjUCZt7DJGN34FJtvbYRI22S6D5uvz5El0tW74= X-Gm-Gg: ASbGncvqauYMDv3BTqLxLoCJQFttemRD+iUcedSuqbmuQYHtTaOh7Cj6hlHdsR/NC1N sIe+48ZSLZmKdWOhmZDc+htdfauM6h0yh12NjlHRTSJF0d1dYStbA+zBQsxuv5byJnFEViO8tGM 3brQjKzIGLbopoSb92av9bnxU1n5ZFvPBPQpFnn1UHhM9kIHRYg0jyBrQtqAYoSDoXuHLH1UtCv SiQcj+NCNj4CgHW4w+fwzC4bQnWZCp/n0Qrq7dX/dLPnVw= X-Google-Smtp-Source: AGHT+IGM7DAMlFDZJVhK/Tgz+xvwbPCNvk2YOKTXtC+n+cDA7T9aGgIQjw40Qp7VtDl1xbBWagyXGw== X-Received: by 2002:a17:902:e808:b0:216:4fad:35d0 with SMTP id d9443c01a7336-219da5cc2c5mr246263585ad.9.1734936893638; Sun, 22 Dec 2024 22:54:53 -0800 (PST) Received: from dw-tp ([129.41.58.7]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc962cf4sm66371595ad.25.2024.12.22.22.54.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Dec 2024 22:54:52 -0800 (PST) From: Ritesh Harjani (IBM) To: Thorsten Blum , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , Hari Bathini , Thomas Gleixner , Thorsten Blum , Thomas =?utf-8?Q?Wei=C3=9Fschuh?= , Baoquan He Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH] powerpc: Use str_on_off() helper in check_cache_coherency() In-Reply-To: <20241220191705.1446-2-thorsten.blum@linux.dev> Date: Mon, 23 Dec 2024 12:24:06 +0530 Message-ID: <87o712lwj5.fsf@gmail.com> References: <20241220191705.1446-2-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Thorsten Blum writes: > Remove hard-coded strings by using the str_on_off() helper function. > > Signed-off-by: Thorsten Blum > --- > arch/powerpc/kernel/setup-common.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c > index 6fa179448c33..f7d7a93f07fc 100644 > --- a/arch/powerpc/kernel/setup-common.c > +++ b/arch/powerpc/kernel/setup-common.c > @@ -834,8 +834,8 @@ static int __init check_cache_coherency(void) > if (devtree_coherency != KERNEL_COHERENCY) { > printk(KERN_ERR > "kernel coherency:%s != device tree_coherency:%s\n", > - KERNEL_COHERENCY ? "on" : "off", > - devtree_coherency ? "on" : "off"); > + str_on_off(KERNEL_COHERENCY), > + str_on_off(devtree_coherency)); > BUG(); > } Looks good to me. Please feel free to add - Reviewed-by: Ritesh Harjani (IBM) -ritesh