From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5054B656; Sun, 18 Feb 2024 08:44:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708245893; cv=none; b=QKFFSuhJxUF0MQ2iu1a+mI9DhryyM7mlygsILVjS4rdt4J8OmPnfv+JNn0tP78zqRVFnPN0sGFx8u4VmNaDrpkDa27vX8aTIfacJd/cR+j2SW6KWYjpjNHOgS+mJfgMmIoGfI393zMFJOaLX0ygJgJNHC9OXMSZ7u4XP/L5EBwI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708245893; c=relaxed/simple; bh=kEFHbH4FktSmQXGiURwDKQgFknhIghk9TihVa9ajmMY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=elDd7xcO8YEx/PGHdSJHVGXhOd3TokqvvI7VzZyGqQnzDOfk6vWegIFISI5Zx3/sWhlmonmWoXpFI0n+V3c+Lb+gn+RiLRDt36eW+ZnlunYh+j0fxBdOcGNy5aAytXHDkSjE6htuOl/pb6dhXEnwiOTPyxQyaLtgtN80G8vydvE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ihMCFkHz; arc=none smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ihMCFkHz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708245891; x=1739781891; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=kEFHbH4FktSmQXGiURwDKQgFknhIghk9TihVa9ajmMY=; b=ihMCFkHzsJB3EAJcJ0IlxjqGtcLsGfURDNEuNpwa6x63vxkOtuCNvfog H7SCV9XFUnJQ1LfEn2xKBMQiFiRT5lFJJWiwdvgYdMrrR+dxLz0DQSpgN wQDISguDmn5rQsFwXD4fFd1h1AIIquzdbwRAMK9x8tn4PTZ7hFhr+EwY2 +AgAxXDBUkoCtL/moa9Ga2IGNhIovhUkpnfadoximWH3iLap6ZbD6zFKW lYUskLwke7jBEM6nB5L5+9e1kK6q77YuwwogyqRJ4iSdm3ZNHQc4IoQJ/ 07OaVxb+FUBWKWBLkq8oxbgvLapkHpB7XTTpWXWWHyK2a7BGlxz4yhaA9 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10987"; a="2203438" X-IronPort-AV: E=Sophos;i="6.06,168,1705392000"; d="scan'208";a="2203438" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2024 00:44:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,168,1705392000"; d="scan'208";a="4584532" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2024 00:44:47 -0800 From: "Huang, Ying" To: Kairui Song Cc: Barry Song <21cnbao@gmail.com>, linux-mm@kvack.org, Andrew Morton , Chris Li , Minchan Kim , Yu Zhao , Barry Song , SeongJae Park , Hugh Dickins , Johannes Weiner , Matthew Wilcox , Michal Hocko , Yosry Ahmed , David Hildenbrand , stable@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] mm/swap: fix race when skipping swapcache In-Reply-To: (Kairui Song's message of "Fri, 16 Feb 2024 18:55:58 +0800") References: <20240216095105.14502-1-ryncsn@gmail.com> Date: Sun, 18 Feb 2024 16:42:50 +0800 Message-ID: <87o7cerwmt.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Kairui Song writes: > On Fri, Feb 16, 2024 at 6:15=E2=80=AFPM Barry Song <21cnbao@gmail.com> wr= ote: >> >> On Fri, Feb 16, 2024 at 10:53=E2=80=AFPM Kairui Song = wrote: >> > >> > From: Kairui Song >> > >> > When skipping swapcache for SWP_SYNCHRONOUS_IO, if two or more threads >> > swapin the same entry at the same time, they get different pages (A, B= ). >> > Before one thread (T0) finishes the swapin and installs page (A) >> > to the PTE, another thread (T1) could finish swapin of page (B), >> > swap_free the entry, then swap out the possibly modified page >> > reusing the same entry. It breaks the pte_same check in (T0) because >> > PTE value is unchanged, causing ABA problem. Thread (T0) will >> > install a stalled page (A) into the PTE and cause data corruption. >> > >> > One possible callstack is like this: >> > >> > CPU0 CPU1 >> > ---- ---- >> > do_swap_page() do_swap_page() with same entry >> > >> > >> > swap_read_folio() <- read to page A swap_read_folio() <- read to page= B >> > >> > .. set_pte_at() >> > swap_free() <- entry is free >> > >> > >> > pte_same() <- Check pass, PTE seems >> > unchanged, but page A >> > is stalled! >> > swap_free() <- page B content lost! >> > set_pte_at() <- staled page A installed! >> > >> > And besides, for ZRAM, swap_free() allows the swap device to discard >> > the entry content, so even if page (B) is not modified, if >> > swap_read_folio() on CPU0 happens later than swap_free() on CPU1, >> > it may also cause data loss. >> > >> > To fix this, reuse swapcache_prepare which will pin the swap entry usi= ng >> > the cache flag, and allow only one thread to pin it. Release the pin >> > after PT unlocked. Racers will simply wait since it's a rare and very >> > short event. A schedule() call is added to avoid wasting too much CPU >> > or adding too much noise to perf statistics >> > >> > Other methods like increasing the swap count don't seem to be a good >> > idea after some tests, that will cause racers to fall back to use the >> > swap cache again. Parallel swapin using different methods leads to >> > a much more complex scenario. >> > >> > Reproducer: >> > >> > This race issue can be triggered easily using a well constructed >> > reproducer and patched brd (with a delay in read path) [1]: >> > >> > With latest 6.8 mainline, race caused data loss can be observed easily: >> > $ gcc -g -lpthread test-thread-swap-race.c && ./a.out >> > Polulating 32MB of memory region... >> > Keep swapping out... >> > Starting round 0... >> > Spawning 65536 workers... >> > 32746 workers spawned, wait for done... >> > Round 0: Error on 0x5aa00, expected 32746, got 32743, 3 data loss! >> > Round 0: Error on 0x395200, expected 32746, got 32743, 3 data loss! >> > Round 0: Error on 0x3fd000, expected 32746, got 32737, 9 data loss! >> > Round 0 Failed, 15 data loss! >> > >> > This reproducer spawns multiple threads sharing the same memory region >> > using a small swap device. Every two threads updates mapped pages one = by >> > one in opposite direction trying to create a race, with one dedicated >> > thread keep swapping out the data out using madvise. >> > >> > The reproducer created a reproduce rate of about once every 5 minutes, >> > so the race should be totally possible in production. >> > >> > After this patch, I ran the reproducer for over a few hundred rounds >> > and no data loss observed. >> > >> > Performance overhead is minimal, microbenchmark swapin 10G from 32G >> > zram: >> > >> > Before: 10934698 us >> > After: 11157121 us >> > Non-direct: 13155355 us (Dropping SWP_SYNCHRONOUS_IO flag) >> > >> > Fixes: 0bcac06f27d7 ("mm, swap: skip swapcache for swapin of synchrono= us device") >> > Link: https://github.com/ryncsn/emm-test-project/tree/master/swap-stre= ss-race [1] >> > Reported-by: "Huang, Ying" >> > Closes: https://lore.kernel.org/lkml/87bk92gqpx.fsf_-_@yhuang6-desk2.c= cr.corp.intel.com/ >> > Signed-off-by: Kairui Song >> > Cc: stable@vger.kernel.org >> > >> > --- >> > Update from V2: >> > - Add a schedule() if raced to prevent repeated page faults wasting CPU >> > and add noise to perf statistics. >> > - Use a bool to state the special case instead of reusing existing >> > variables fixing error handling [Minchan Kim]. >> > >> > V2: https://lore.kernel.org/all/20240206182559.32264-1-ryncsn@gmail.co= m/ >> > >> > Update from V1: >> > - Add some words on ZRAM case, it will discard swap content on swap_fr= ee so the race window is a bit different but cure is the same. [Barry Song] >> > - Update comments make it cleaner [Huang, Ying] >> > - Add a function place holder to fix CONFIG_SWAP=3Dn built [SeongJae P= ark] >> > - Update the commit message and summary, refer to SWP_SYNCHRONOUS_IO i= nstead of "direct swapin path" [Yu Zhao] >> > - Update commit message. >> > - Collect Review and Acks. >> > >> > V1: https://lore.kernel.org/all/20240205110959.4021-1-ryncsn@gmail.com/ >> > >> > include/linux/swap.h | 5 +++++ >> > mm/memory.c | 20 ++++++++++++++++++++ >> > mm/swap.h | 5 +++++ >> > mm/swapfile.c | 13 +++++++++++++ >> > 4 files changed, 43 insertions(+) >> > >> > diff --git a/include/linux/swap.h b/include/linux/swap.h >> > index 4db00ddad261..8d28f6091a32 100644 >> > --- a/include/linux/swap.h >> > +++ b/include/linux/swap.h >> > @@ -549,6 +549,11 @@ static inline int swap_duplicate(swp_entry_t swp) >> > return 0; >> > } >> > >> > +static inline int swapcache_prepare(swp_entry_t swp) >> > +{ >> > + return 0; >> > +} >> > + >> > static inline void swap_free(swp_entry_t swp) >> > { >> > } >> > diff --git a/mm/memory.c b/mm/memory.c >> > index 7e1f4849463a..7059230d0a54 100644 >> > --- a/mm/memory.c >> > +++ b/mm/memory.c >> > @@ -3799,6 +3799,7 @@ vm_fault_t do_swap_page(struct vm_fault *vmf) >> > struct page *page; >> > struct swap_info_struct *si =3D NULL; >> > rmap_t rmap_flags =3D RMAP_NONE; >> > + bool need_clear_cache =3D false; >> > bool exclusive =3D false; >> > swp_entry_t entry; >> > pte_t pte; >> > @@ -3867,6 +3868,20 @@ vm_fault_t do_swap_page(struct vm_fault *vmf) >> > if (!folio) { >> > if (data_race(si->flags & SWP_SYNCHRONOUS_IO) && >> > __swap_count(entry) =3D=3D 1) { >> > + /* >> > + * Prevent parallel swapin from proceeding with >> > + * the cache flag. Otherwise, another thread m= ay >> > + * finish swapin first, free the entry, and sw= apout >> > + * reusing the same entry. It's undetectable as >> > + * pte_same() returns true due to entry reuse. >> > + */ >> > + if (swapcache_prepare(entry)) { >> > + /* Relax a bit to prevent rapid repeat= ed page faults */ >> > + schedule(); >> > + goto out; >> > + } >> > + need_clear_cache =3D true; >> >> Hi Kairui, >> i remember Ying had a suggestion to move swapcache_prepare after >> swap_read_folio() to decrease race window. does that one even help >> more to somehow "fix" the counting issue? >> > > Hi Barry, > > Thanks for the comments! > > Yes, that's one of the suggestions, I found the result already looks > good enough in test scenario I've posted after adding scheduler() > change. After moving swapcache_prepare actually waste more CPU as it > need to alloc/free extra folios now, and test result for the counting > issue barely changed, so I kept the original code. The time to allocate folios is unbounded, especially when direct reclaiming is triggered. And we can clear swap cache flag earlier to reduce the race window too. -- Best Regards, Huang, Ying