From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8841AC77B7A for ; Tue, 30 May 2023 07:44:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229754AbjE3HoE (ORCPT ); Tue, 30 May 2023 03:44:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231299AbjE3HnZ (ORCPT ); Tue, 30 May 2023 03:43:25 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF4B519D for ; Tue, 30 May 2023 00:43:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8ACA962110 for ; Tue, 30 May 2023 07:41:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E86F7C433D2; Tue, 30 May 2023 07:41:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685432498; bh=49h+SolxOYzwjmP6VMR9DIpbnad7Kor0ec2BjVpwFLo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=AwI2o0uoLTFksZ901spytwpQfsXr3CNw/5v36F46FNy3BSwZInX9NU72yPANZ/lEN d6iTn2iPcmx52Gk0WAAFVGv0fOGPi/WprpmQVtCEN4HjUgfn0oCsCaRIii9BSFse8X gg8NoovNMkpwyz9V7OtO0nTaXhi+58J10gGhAZ/jM42zR1/vlChPTc9PQut5I4FtSu 6Ie6hxO6sHEPJL7RhThqaZUWqa0+Ir3hf3QOpC04VQmFhtErZ3bUwiKPeE0xy4xGDM z84QJfthzFia+m3Zl97CGrnCcK9Y6E7P7YdCvAfKWszGz3CIIa6fbUf7d692yCSQUG c6xTYbStjeV5A== Received: from ip-185-104-136-29.ptr.icomera.net ([185.104.136.29] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1q3tz5-001EQT-LZ; Tue, 30 May 2023 08:41:35 +0100 Date: Tue, 30 May 2023 08:41:33 +0100 Message-ID: <87o7m2jmfm.wl-maz@kernel.org> From: Marc Zyngier To: Akihiko Odaki Cc: James Morse , Suzuki K Poulose , Oliver Upton , Zenghui Yu , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] KVM: arm64: Populate fault info for watchpoint In-Reply-To: <20230530024651.10014-1-akihiko.odaki@daynix.com> References: <20230530024651.10014-1-akihiko.odaki@daynix.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.104.136.29 X-SA-Exim-Rcpt-To: akihiko.odaki@daynix.com, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 30 May 2023 03:46:51 +0100, Akihiko Odaki wrote: > > When handling ESR_ELx_EC_WATCHPT_LOW, far_el2 member of struct > kvm_vcpu_fault_info will be copied to far member of struct > kvm_debug_exit_arch and exposed to the userspace. The userspace will > see stale values from older faults if the fault info does not get > populated. > > Fixes: 8fb2046180a0 ("KVM: arm64: Move early handlers to per-EC handlers") > Suggested-by: Marc Zyngier > Signed-off-by: Akihiko Odaki Thanks for respining this quickly. I've added a Cc: stable as we need to get this backported. Cheers, M. -- Without deviation from the norm, progress is not possible.