From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56A72C2BB55 for ; Tue, 7 Apr 2020 14:09:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 37E8C2074F for ; Tue, 7 Apr 2020 14:09:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728968AbgDGOJn (ORCPT ); Tue, 7 Apr 2020 10:09:43 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:47520 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728482AbgDGOJn (ORCPT ); Tue, 7 Apr 2020 10:09:43 -0400 Received: from [5.158.153.52] (helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1jLov5-0006yk-TB; Tue, 07 Apr 2020 16:09:39 +0200 Received: by nanos.tec.linutronix.de (Postfix, from userid 1000) id 7A0E9101303; Tue, 7 Apr 2020 16:09:39 +0200 (CEST) From: Thomas Gleixner To: Jan Kara Cc: Andrei Vagin , LKML , Jan Kara , stable@vger.kernel.org Subject: Re: [PATCH] ucount: Fix wrong inotify ucounts in /proc/sys/user In-Reply-To: <20200407121814.26073-1-jack@suse.cz> References: <20200407121814.26073-1-jack@suse.cz> Date: Tue, 07 Apr 2020 16:09:39 +0200 Message-ID: <87o8s3jskc.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jan Kara writes: > Commit 769071ac9f20 "ns: Introduce Time Namespace" broke reporting of > inotify ucounts (max_inotify_instances, max_inotify_watches) in > /proc/sys/user because it has added UCOUNT_TIME_NAMESPACES into enum > ucount_type but didn't properly update reporting in > kernel/ucount.c:setup_userns_sysctls(). Update the reporting to fix the > issue and also add BUILD_BUG_ON to catch a similar problem in the > future. Just merged that: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=timers/urgent&id=eeec26d5da8248ea4e240b8795bb4364213d3247 Could you please send a patch with just the build bug on ? Thanks, tglx