From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753300AbdKWSro (ORCPT ); Thu, 23 Nov 2017 13:47:44 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:40436 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753195AbdKWSrl (ORCPT ); Thu, 23 Nov 2017 13:47:41 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20171123184739euoutp028495f87bd9989512ee856694079853d6~5y3ZVWToG0721107211euoutp02- X-AuditID: cbfec7f5-f79d06d0000031c7-3a-5a1717c916fa From: =?utf-8?Q?=C5=81ukasz_Stelmach?= To: Krzysztof Kozlowski Cc: Rob Herring , Matt Mackall , Herbert Xu , devicetree@vger.kernel.org, linux-crypto@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Marek Szyprowski , Bartlomiej Zolnierkiewicz Subject: Re: [PATCH 2/3] hwrng: exynos - add Samsung Exynos True RNG driver Date: Thu, 23 Nov 2017 19:46:24 +0100 In-reply-to: Message-id: <87o9nsde9r.fsf%l.stelmach@samsung.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-version: 1.0 Content-type: multipart/signed; boundary="=-=-="; micalg="pgp-sha256"; protocol="application/pgp-signature" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrBKsWRmVeSWpSXmKPExsWy7djP87onxcWjDA7d0bLYOGM9q8X8I+dY LbpfyVicP7+B3eL+vZ9MFpd3zWGzmHF+H5PF2iN32S0WbOtjtGjde4Tdgctj2wFVj02rOtk8 +rasYvToe7mB0ePzJrkA1igum5TUnMyy1CJ9uwSujL9Nm1gKdihVnF30iamBcZlUFyMnh4SA icTxfYvYIWwxiQv31rN1MXJxCAksZZRYd3QaK4TzmVFi0ZTFzDAd6y49ZoRILGOUmDt7NTuE 84VR4kDTTBaQKjYBe4n+I/vAbBEBTYnrf7+DjWIWuMIkcXnbNaYuRg4OYQFviSn/rUFqWARU JQ5172UFsTkFgiWunLoGto1XwFji4u1usPtEBSwl7vXdZYOIC0r8mHwPbD6zQK7Ep6b/UD/8 ZpN4tNwbwnaRWHm/kwXCFpZ4dXwLVI2MRGfHQSaQeyQE+hklDs//DpWYwiixeKEDhG0t8WfV RDaIBXwSk7ZNZwa5WUKAV6KjTQjC9JDYdkIHotpR4uiUc2DVQgJLGCVeP1aewCg7C8mls5Bc OguomxkYKut36UOEtSWWLXzNDGHbSqxb955lASPrKkaR1NLi3PTUYlO94sTc4tK8dL3k/NxN jMA0c/rf8a87GJceszrEKMDBqMTDK/FALEqINbGsuDL3EKMK0JhHG1ZfYJRiycvPS1US4ZV/ CpTmTUmsrEotyo8vKs1JLT7EKM3BoiTOaxvVFikkkJ5YkpqdmlqQWgSTZeLglGpgNBLq7nTv TT78fuXd2pMnL2zfdfh42rJJqkJLHnSEK1e5vzIqubIn4VP/U0Vfp9VPLi38bfmf1SpoQtC5 uE0JUb/EmINPeUv90N06bTmTYarysiLOm/N2ydYnrH9QyFdiKsT3Qv6zC+vUnVlPZ8kuN0x8 MbWHme9U1bfQ97d9+OQTmQzyXOTTlViKMxINtZiLihMB3gv83TsDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrPLMWRmVeSWpSXmKPExsVy+t/xa7onxMWjDOb9k7bYOGM9q8X8I+dY LbpfyVicP7+B3eL+vZ9MFpd3zWGzmHF+H5PF2iN32S0WbOtjtGjde4Tdgctj2wFVj02rOtk8 +rasYvToe7mB0ePzJrkA1igum5TUnMyy1CJ9uwSujL9Nm1gKdihVnF30iamBcZlUFyMnh4SA icS6S48ZIWwxiQv31rN1MXJxCAksYZQ4vamJFcL5xihxYdcUVpAqNgF7if4j+1hAbBEBTYnr f7+DFTELXGGSeHDkFFA7B4ewgLfElP/WIDVCAgESd48+ZAexWQRUJQ517wWbwykQLHH+ywc2 EJtXwFji4u1usBpRAUuJe313oeKCEj8m3wPbxSyQLXHh4huWCYz8s5CkZiFJzQLazAx00vpd +hBhbYllC18zQ9i2EuvWvWdZwMi6ilEktbQ4Nz232FCvODG3uDQvXS85P3cTIzAqth37uXkH 46WNwYcYBTgYlXh4Cx6JRQmxJpYVV+YeYlQBGvNow+oLjFIsefl5qUoivPJPgdK8KYmVValF +fFFpTmpxYcYpTlYlMR5e/esjhQSSE8sSc1OTS1ILYLJMnFwSjUwGm57nyQjsuN+vrtghfkT +ZzJGV8FhX5kSyh1/Fs44Z37g4S6hTtDRRQFwmqO/pgefP36DZGvzX9N19izBnFvfJnsXjPv OZNCjr8lY7bH01mf77w6uPKc4JxXPyfceLzvSEkHa6OS95UcWZ1N7rHFfZU+tj4/NcqnSF4O PnXijW2aeeYOzvyLSizFGYmGWsxFxYkAx8o76ZICAAA= X-CMS-MailID: 20171123184736eucas1p15d4e73d5a6596a6cba1f940dcc473c9a X-Msg-Generator: CA CMS-TYPE: 201P X-CMS-RootMailID: 20171123184736eucas1p15d4e73d5a6596a6cba1f940dcc473c9a X-RootMTR: 20171123184736eucas1p15d4e73d5a6596a6cba1f940dcc473c9a References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable It was <2017-11-23 czw 17:31>, when Krzysztof Kozlowski wrote: > On Thu, Nov 23, 2017 at 4:09 PM, =C5=81ukasz Stelmach wrote: >> Add support for True Random Number Generator found in Samsung Exynos >> 5250+ SoCs. >> >> Signed-off-by: =C5=81ukasz Stelmach >> --- >> MAINTAINERS | 7 + >> drivers/char/hw_random/Kconfig | 12 ++ >> drivers/char/hw_random/Makefile | 1 + >> drivers/char/hw_random/exynos-trng.c | 256 ++++++++++++++++++++++++++++= +++++++ >> 4 files changed, 276 insertions(+) >> create mode 100644 drivers/char/hw_random/exynos-trng.c >> [...] >> endif # HW_RANDOM > > Thanks for working on TRNG. > > 1. I was rather thinking about extending existing exynos-rng.c [1] so > it would be using TRNG as seed for PRNG as this gives you much more > random data. Instead you developed totally separate driver which has > its own benefits - one can choose which interface he wants. Although > it is a little bit duplication. As far as I can tell, these are two different devices. However, PRNG shares hardware with the hash engine. Indeed there is a hardware to connect TRNG and PRNG, but, IMHO, it might be hard to model that dependency in kernel. To me it seems easier to read TRNG (or /dev/random) and and write the result to PRNG manually (in software). > 2. I understand that in your current version of TRNG driver there is > no conflict with PRNG and they can work both at the same time? I guess so. I expect no problems as long as TRNG_SEED_START is not set in the HASH_SEED_CONF register. > [1] > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/d= rivers/crypto/exynos-rng.c > >> + >> + trng->rng.init =3D exynos_trng_init; >> + trng->rng.read =3D exynos_trng_do_read; >> + trng->rng.priv =3D (unsigned long) trng; >> + >> + platform_set_drvdata(pdev, trng); >> + trng->dev =3D &pdev->dev; >> + >> + res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); >> + trng->mem =3D devm_ioremap_resource(&pdev->dev, res); >> + if (IS_ERR(trng->mem)) { >> + dev_err(&pdev->dev, "Couldn't map IO resources.\n"); >> + ret =3D PTR_ERR(trng->mem); >> + goto err_ioremap; >> + } >> + >> + pm_runtime_enable(&pdev->dev); >> + ret =3D pm_runtime_get_sync(&pdev->dev); >> + if (ret < 0) { >> + dev_err(&pdev->dev, "pm_runtime_get_sync() failed: %d.\n= ", ret); >> + goto err_ioremap; > > Missing pm_runtime_disable? Added a separate label down below. >> + dev_err(&pdev->dev, "Couldn't get clock.\n"); >> + ret =3D PTR_ERR(trng->clk); >> + goto err_clock; >> + } >> + >> + ret =3D clk_prepare_enable(trng->clk); >> + if (ret) { >> + dev_err(&pdev->dev, "Unable to enable the clk: %d.\n", r= et); >> + goto err_clock; >> + } >> + >> + ret =3D hwrng_register(&trng->rng); >> + if (ret) { >> + dev_err(&pdev->dev, "Couldn't register hwrng device.\n"); >> + goto err_register; >> + } >> + >> + dev_info(&pdev->dev, "Exynos True Random Number Generator.\n"); >> + >> + return 0; >> + >> +err_register: >> + clk_disable_unprepare(trng->clk); >> + >> +err_clock: >> + trng->mem =3D NULL; > > Why this has to be null-ified? I found this pattern in omap-rng.c. Removed. I'll wait a little bit more before posting v2. =2D-=20 =C5=81ukasz Stelmach Samsung R&D Institute Poland Samsung Electronics --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBCAAGBQJaFxeAAAoJELCuHpyYpYAQlbgH/3M4djvomtz2/xlNiURwk5xG XEao8jOBO8voEi17NR3rOSkSTQ/w+tEBEdKntlmCms4z0KfOzwQF4CbKubLtb56K cdpRzvXNd6BxrV998in2pDfLYPHRvpL0IJnDVxnhCzYBv7eBitXaYizogokRTQgI hldTBgzBKU8ul1hQXjDOd6PIR8DLUTcXMnyV1Xtw2P9jENMvupWWDzxO1Thp51uB wC6XdX6YC89wvu5p3PevzxiHaRQCok7fLiLNth6zlPpXVG+Cy5vOmXO9q8cSI4Qz wurANxC/KMbZBovNP+LzKKfkvV9Vaoy4kjGVzwdyfqeYKaLK48l2Eqtnjtspo/U= =IiNf -----END PGP SIGNATURE----- --=-=-=--