mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Thomas Gleixner <tglx@linutronix.de>,
	Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com>
Cc: Daniel Black <daniel.black@au1.ibm.com>,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc: Drop lockdep_assert_cpus_held call from arch_update_cpu_topology
Date: Tue, 10 Oct 2017 20:48:36 +1100	[thread overview]
Message-ID: <87o9pfwcy3.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <alpine.DEB.2.20.1710052031590.2398@nanos>

Thomas Gleixner <tglx@linutronix.de> writes:
...
>
> So no, the lockdep assertion triggers in #1 and #2 because
>
>    #1 does definitely not hold it
>
>    #2 is indirectily protected, but we have no way to express that to lockdep
>
> So yes, it's safe for both cases to remove that assertion.

Thanks for clarifying that.

> If there are other call sites, then they need to be checked. If not, you're
> good.

I also see a call in partition_sched_domains(). The comment there says
"call with hotplug lock held" and I'm sure all callers do so ...

But seriously I think the patch is good because we know there are at
least two callers who are safe but can't hold the lock, so doing an
assert there is definitely wrong.

So I'll apply the patch with a slightly reworked commit message.

cheers

  reply	other threads:[~2017-10-10  9:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-05  0:04 Thiago Jung Bauermann
2017-10-05 12:38 ` Thomas Gleixner
2017-10-05 18:26   ` Thiago Jung Bauermann
2017-10-05 18:46     ` Thomas Gleixner
2017-10-10  9:48       ` Michael Ellerman [this message]
2017-10-12  0:20 ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o9pfwcy3.fsf@concordia.ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=bauerman@linux.vnet.ibm.com \
    --cc=daniel.black@au1.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®