From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Arjan van de Ven <arjan@linux.intel.com>,
Borislav Petkov <bp@alien8.de>,
Richard Weinberger <richard.weinberger@gmail.com>,
Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org,
Jason Wessel <jason.wessel@windriver.com>
Subject: Re: [PATCH] x86/debug: Handle warnings before the notifier chain
Date: Tue, 29 Aug 2017 14:53:52 +0300 [thread overview]
Message-ID: <87o9qyy4hb.fsf@ashishki-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20170724102140.yjmruyecl7gxg3q7@hirez.programming.kicks-ass.net>
Peter Zijlstra <peterz@infradead.org> writes:
> On Mon, Jul 24, 2017 at 01:04:28PM +0300, Alexander Shishkin wrote:
>> Commit
>>
>> 9a93848fe787 ("x86/debug: Implement __WARN() using UD0")
>>
>> turned warnings into UD0, but the fixup code only runs after the
>> notify_die() chain. This is a problem, in particular, with kgdb,
>> which kicks in as if it was a BUG().
>>
>> Fix this by running the fixup code before the notifier chain in
>> the invalid op handler path.
>
> So arguable it might be nice to have kgdb trap on a WARN, but it
> treating it as a BUG is obviously undesirable.
>
> Jason, what would you want kgdb to do here?
Ping.
next prev parent reply other threads:[~2017-08-29 11:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-24 10:04 Alexander Shishkin
2017-07-24 10:21 ` Peter Zijlstra
2017-08-29 11:53 ` Alexander Shishkin [this message]
2017-11-10 6:33 ` [tip:x86/urgent] x86/debug: Handle warnings before the notifier chain, to fix KGDB crash tip-bot for Alexander Shishkin
2017-11-10 9:41 ` tip-bot for Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9qyy4hb.fsf@ashishki-desk.ger.corp.intel.com \
--to=alexander.shishkin@linux.intel.com \
--cc=arjan@linux.intel.com \
--cc=bp@alien8.de \
--cc=jason.wessel@windriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=richard.weinberger@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®