From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753738AbdCHODv (ORCPT <rfc822;w@1wt.eu>);
        Wed, 8 Mar 2017 09:03:51 -0500
Received: from foss.arm.com ([217.140.101.70]:59712 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753682AbdCHODg (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 8 Mar 2017 09:03:36 -0500
From: Marc Zyngier <marc.zyngier@arm.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>,
        <virtualization@lists.linux-foundation.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] virtio-pci: Remove affinity hint before freeing the interrupt
In-Reply-To: <20170308151940-mutt-send-email-mst@kernel.org> (Michael
        S. Tsirkin's message of "Wed, 8 Mar 2017 15:28:13 +0200")
Organization: ARM Ltd
References: <20170308080927.4493-1-marc.zyngier@arm.com>
        <20170308151940-mutt-send-email-mst@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
Date: Wed, 08 Mar 2017 14:03:29 +0000
Message-ID: <87o9xbyifi.fsf@on-the-bus.cambridge.arm.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 08 2017 at  1:28:13 pm GMT, "Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Wed, Mar 08, 2017 at 08:09:27AM +0000, Marc Zyngier wrote:
>> virtio-pci registers a per-vq affinity hint when using MSIX,
>> but fails to remove it when freeing the interrupt, resulting
>> in this type of splat:
>> 
>> [   31.111202] WARNING: CPU: 0 PID: 2823 at kernel/irq/manage.c:1503 __free_irq+0x2c4/0x2c8
>> [   31.114689] Modules linked in:
>> [   31.116101] CPU: 0 PID: 2823 Comm: kexec Not tainted 4.10.0+ #6941
>> [   31.118911] Hardware name: Generic DT based system
>> [   31.121319] [<c022fb78>] (unwind_backtrace) from [<c0229d8c>] (show_stack+0x18/0x1c)
>> [   31.125017] [<c0229d8c>] (show_stack) from [<c05192f4>] (dump_stack+0x84/0x98)
>> [   31.128427] [<c05192f4>] (dump_stack) from [<c023d940>] (__warn+0xf4/0x10c)
>> [   31.131910] [<c023d940>] (__warn) from [<c023da20>] (warn_slowpath_null+0x28/0x30)
>> [   31.135543] [<c023da20>] (warn_slowpath_null) from [<c0290238>] (__free_irq+0x2c4/0x2c8)
>> [   31.139355] [<c0290238>] (__free_irq) from [<c02902d0>] (free_irq+0x44/0x78)
>> [   31.142909] [<c02902d0>] (free_irq) from [<c059d3a8>] (vp_del_vqs+0x68/0x1c0)
>> [   31.146299] [<c059d3a8>] (vp_del_vqs) from [<c056ca4c>] (pci_device_shutdown+0x3c/0x78)
>> 
>> The obvious fix is to drop the affinity hint before freeing the
>> interrupt.
>> 
>> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
>
> Is this introduced by the changes in latest rc?

No, this was there already in 4.10, just in a different function (I had
to rebase the fix, as I originally fixed vp_del_vqs). -rc1 just moved
the bug to a new function.

Thanks,

	M.
-- 
Jazz is not dead, it just smell funny.