From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752550AbcHHSbv (ORCPT ); Mon, 8 Aug 2016 14:31:51 -0400 Received: from canardo.mork.no ([148.122.252.1]:56544 "EHLO canardo.mork.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752497AbcHHSbt convert rfc822-to-8bit (ORCPT ); Mon, 8 Aug 2016 14:31:49 -0400 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= To: Oliver Neukum Cc: Kristian Evensen , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Network Development Subject: Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Organization: m References: <1468844691-8222-1-git-send-email-kristian.evensen@gmail.com> <1468846886.2280.6.camel@suse.com> <1468849802.2280.11.camel@suse.com> <1468851242.2280.14.camel@suse.com> <87y4475t2f.fsf@miraculix.mork.no> <1470664620.3175.18.camel@suse.com> Date: Mon, 08 Aug 2016 20:30:35 +0200 In-Reply-To: <1470664620.3175.18.camel@suse.com> (Oliver Neukum's message of "Mon, 08 Aug 2016 15:57:00 +0200") Message-ID: <87oa535d10.fsf@miraculix.mork.no> User-Agent: Gnus/5.130015 (Ma Gnus v0.15) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Oliver Neukum writes: > But why fix similar issues at two different places? And what about > PCI or other cards that show the same problem? I guess some sort of common helper would be nice to avoid open coding this fix everywhere. But you would still have to modify every driver where it is applicable, as there is no existing common API. Note that this doesn't include *every* ethernet driver, although there certainly are some examples. There are also a number of serious vendors, providing vendor supported drivers for cards with no known issues of this kind. Where exactly would you like to see this implemented if it isn't going into those specific usbnet drivers? Bjørn