From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755500AbcHBARi (ORCPT ); Mon, 1 Aug 2016 20:17:38 -0400 Received: from smtp07.smtpout.orange.fr ([80.12.242.129]:16608 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755393AbcHBAR3 (ORCPT ); Mon, 1 Aug 2016 20:17:29 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Mon, 01 Aug 2016 21:10:32 +0200 X-ME-IP: 86.199.194.242 From: Robert Jarzmik To: Kishon Vijay Abraham I Cc: Tony Lindgren , Nicolas Ferre , Alexandre Belloni , Jean-Christophe Plagniol-Villard , Krzysztof Halasa , Kukjin Kim , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Santosh Shilimkar , Daniel Mack , Haojian Zhuang , Simon Horman , Magnus Damm , Viresh Kumar , Shiraz Hashim , Arnd Bergmann , , Benoit Cousson , Rob Herring , Mark Rutland , Russell King , Fabio Estevam , Greg Ungerer , , , , , , , , Subject: Re: [RFT PATCH v2 2/3] ARM: Fix *MIGHT_HAVE_PCI* config from being selected redundantly References: <1470049950-4697-1-git-send-email-kishon@ti.com> <1470049950-4697-3-git-send-email-kishon@ti.com> X-URL: http://belgarath.falguerolles.org/ Date: Mon, 01 Aug 2016 21:10:22 +0200 In-Reply-To: <1470049950-4697-3-git-send-email-kishon@ti.com> (Kishon Vijay Abraham, I's message of "Mon, 1 Aug 2016 16:42:29 +0530") Message-ID: <87oa5cxq3l.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kishon Vijay Abraham I writes: > *MIGHT_HAVE_PCI* config is already selected in ARCH_MULTIPLATFORM. > Fix it from getting redundantly selected in all > ARCH_MULTIPLATFORM based machines. If that's the purpose, then CM-X255 and CM-X270 don't fall in that category, as they are not part of ARCH_MULTIPLATFORM nor ready for it AFAIK. So the change below shouldn't be done according to the commit message. > diff --git a/arch/arm/mach-pxa/Kconfig b/arch/arm/mach-pxa/Kconfig > index cd894d6..39f7755 100644 > --- a/arch/arm/mach-pxa/Kconfig > +++ b/arch/arm/mach-pxa/Kconfig > @@ -113,7 +113,6 @@ config MACH_ARMCORE > bool "CompuLab CM-X255/CM-X270 modules" > select ARCH_HAS_DMA_SET_COHERENT_MASK if PCI > select IWMMXT > - select MIGHT_HAVE_PCI > select NEED_MACH_IO_H if PCI > select PXA25x > select PXA27x Cheers. -- Robert