From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932966AbcDYQHc (ORCPT <rfc822;w@1wt.eu>);
	Mon, 25 Apr 2016 12:07:32 -0400
Received: from mga03.intel.com ([134.134.136.65]:29191 "EHLO mga03.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754683AbcDYQHb (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 25 Apr 2016 12:07:31 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,533,1455004800"; 
   d="scan'208";a="952530955"
From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org,
        vince@deater.net, eranian@google.com,
        Arnaldo Carvalho de Melo <acme@infradead.org>,
        Mathieu Poirier <mathieu.poirier@linaro.org>
Subject: Re: [PATCH v1 4/5] perf: Introduce address range filtering
In-Reply-To: <20160425141420.GI3430@twins.programming.kicks-ass.net>
References: <1461251823-12416-1-git-send-email-alexander.shishkin@linux.intel.com> <1461251823-12416-5-git-send-email-alexander.shishkin@linux.intel.com> <20160422074555.GB3448@twins.programming.kicks-ass.net> <87zisl8vls.fsf@ashishki-desk.ger.corp.intel.com> <20160425141420.GI3430@twins.programming.kicks-ass.net>
User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu)
Date: Mon, 25 Apr 2016 19:07:12 +0300
Message-ID: <87oa8x8yfj.fsf@ashishki-desk.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Peter Zijlstra <peterz@infradead.org> writes:

> On Fri, Apr 22, 2016 at 07:19:11PM +0300, Alexander Shishkin wrote:
>>  /**
>> + * struct perf_addr_filter - address range filter definition
>> + * @entry:	event's filter list linkage
>> + * @inode:	object file's inode for file-based filters
>> + * @offset:	filter range offset
>> + * @size:	filter range size
>> + * @range:	1: range, 0: address
>> + * @filter:	1: filter/start, 0: stop
>> + * @kernel:	1: kernel, 0: file-based
>> + *
>> + * This is a hardware-agnostic filter configuration as specified by the user.
>> + */
>> +struct perf_addr_filter {
>> +	struct list_head	entry;
>> +	struct inode		*inode;
>> +	unsigned long		offset;
>> +	unsigned long		size;
>> +	unsigned int		range	: 1,
>> +				filter	: 1,
>> +				kernel	: 1;
>> +};
>
> FWIW, why not have !inode be kernel?

It actually can, you're right.

Regards,
--
Alex