mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@kernel.org>
To: "Du\, Changbin" <changbin.du@intel.com>
Cc: "gregkh\@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"linux-usb\@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 0/3] Improvement, fix and new entry for dwc3 debugfs
Date: Thu, 07 Apr 2016 08:22:27 +0300	[thread overview]
Message-ID: <87oa9myovg.fsf@intel.com> (raw)
In-Reply-To: <0C18FE92A7765D4EB9EE5D38D86A563A05CEBDCF@shsmsx102.ccr.corp.intel.com>

[-- Attachment #1: Type: text/plain, Size: 1136 bytes --]


HI

"Du, Changbin" <changbin.du@intel.com> writes:
>> before I review your patches, one comment
>> 
>> changbin.du@intel.com writes:
>> > From: "Du, Changbin" <changbin.du@intel.com>
>> >
>> > The first patch removed unnecessary checking for debugfs api call;
>> > The second patch fix a memory leak issue;
>> > The third patch add one new entry to debufs.
>> >
>> > Du, Changbin (3):
>> >   usb: dwc3: make dwc3_debugfs_init return value be void
>> 
>> this is _not_ a fix
>> 
>> >   usb: dwc3: free dwc->regset on dwc3_debugfs_exit
>> 
>> but this is. Why isn't this, at least, the first patch in the list ? In
>> fact, it would be preferred that this patch be sent by itself and the
>> following two patches should be on another branch completely without any
>> dependencies to the memory leak fix.
>> 
>> --
>> Balbi
>
> Sure, Balbi. This will be better. I will send out patch v3 and another independent
> patch. Also include changelog as Greg required. Thanks for checking.

thanks, that way we can get the fix during the -rc cycle and the other
two patches on next merge window ;-)

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

  reply	other threads:[~2016-04-07  5:24 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-06  8:27 [PATCH] usb: dwc3: add debugfs node to dump FIFO/Queue available space changbin.du
2016-04-06  9:25 ` Greg KH
2016-04-06 11:38   ` Du, Changbin
2016-04-06 12:24     ` Felipe Balbi
2016-04-06 15:44   ` [PATCH v2 0/3] Improvement, fix and new entry for dwc3 debugfs changbin.du
2016-04-07  5:05     ` Felipe Balbi
2016-04-07  5:21       ` Du, Changbin
2016-04-07  5:22         ` Felipe Balbi [this message]
2016-04-08  9:34       ` [PATCH v3 0/2] Add a new debugfs entry to dump FIFO/Queue available space changbin.du
2016-04-08  9:34       ` [PATCH v3 1/2] usb: dwc3: make dwc3_debugfs_init return value be void changbin.du
2016-04-11  8:14         ` Felipe Balbi
2016-04-11 11:19           ` Du, Changbin
2016-04-11 11:23             ` Felipe Balbi
2016-04-12 11:10               ` [PATCH v4 0/2] Add a new debugfs entry to dump FIFO/Queue available space changbin.du
2016-04-12 11:10               ` [PATCH v4 1/2] usb: dwc3: make dwc3_debugfs_init return value be void changbin.du
2016-04-12 11:10               ` [PATCH v4 2/2] usb: dwc3: add debugfs node to dump FIFO/Queue available space changbin.du
2016-04-12 12:58                 ` Sergei Shtylyov
2016-04-14  3:27                   ` Du, Changbin
2016-04-14  8:02                 ` Felipe Balbi
2016-04-14 11:15                   ` Du, Changbin
2016-04-14 11:18                     ` Felipe Balbi
2016-04-14 11:37                       ` Du, Changbin
2016-04-14 11:41                         ` Felipe Balbi
2016-04-14 11:58                           ` Du, Changbin
2016-04-08  9:34       ` [PATCH v3 " changbin.du
2016-04-06 15:44   ` [PATCH v2 1/3] usb: dwc3: make dwc3_debugfs_init return value be void changbin.du
2016-04-06 15:44   ` [PATCH v2 2/3] usb: dwc3: free dwc->regset on dwc3_debugfs_exit changbin.du
2016-04-06 21:08     ` Greg KH
2016-04-07  5:05     ` Felipe Balbi
2016-04-06 15:44   ` [PATCH v2 3/3] usb: dwc3: add debugfs node to dump FIFO/Queue available space changbin.du

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87oa9myovg.fsf@intel.com \
    --to=balbi@kernel.org \
    --cc=changbin.du@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome