From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753644AbbJSNeW (ORCPT ); Mon, 19 Oct 2015 09:34:22 -0400 Received: from mga03.intel.com ([134.134.136.65]:45794 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751636AbbJSNeT (ORCPT ); Mon, 19 Oct 2015 09:34:19 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,702,1437462000"; d="scan'208";a="830000340" From: Alexander Shishkin To: Mathieu Poirier , gregkh@linuxfoundation.org, a.p.zijlstra@chello.nl, acme@kernel.org, mingo@redhat.com, corbet@lwn.net, nicolas.pitre@linaro.org Cc: adrian.hunter@intel.com, zhang.chunyan@linaro.org, mike.leach@arm.com, tor@ti.com, al.grant@arm.com, pawel.moll@arm.com, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, mathieu.poirier@linaro.org Subject: Re: [PATCH V2 17/30] perf: changing pmu::setup_aux() parameter to include event In-Reply-To: <1445192687-24112-18-git-send-email-mathieu.poirier@linaro.org> References: <1445192687-24112-1-git-send-email-mathieu.poirier@linaro.org> <1445192687-24112-18-git-send-email-mathieu.poirier@linaro.org> User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Mon, 19 Oct 2015 16:34:13 +0300 Message-ID: <87oafvgey2.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mathieu Poirier writes: > For some tracers the event carries information to be embedded > in the private structure returned by setup_aux(). You need to mention here what these tracers are and which bits of event's information they need in their setup_aux(). Right now I can look it up in this patchset, but when this code gets merged it will make it easier to understand why this change was made. Now, I understand that you're interested in event::attr in your setup_aux(), I have more comments on that in that other patch. :) Cheers, -- Alex