Re: [PATCH 16/18] perf evsel: Introduce perf_evsel__{str,int}val methods

[Namhyung Kim <namhyung@kernel.org>]

On Tue, 11 Sep 2012 20:53:08 -0300, Arnaldo Carvalho de Melo wrote:
> From: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> Wrappers to the libtraceevent routines, so that we can further reduce
> the surface contact perf builtins have with it.
[snip]
> +char *perf_evsel__strval(struct perf_evsel *evsel, struct perf_sample *sample,
> +			 const char *name)
> +{
> +	struct format_field *field = pevent_find_field(evsel->tp_format, name);
> +	int offset;
> +
> +        if (!field)
> +                return NULL;

Whitespace problem?

Btw, as a generic wrapper shouldn't it handle common fields also?  If
you care about performance, how about switching the order of finding
fields in question, i.e.:

	struct format_field *field = pevent_find_field(evsel->tp_format, name);

	if (!field) {
		field = pevent_find_common_field(evsel->tp_format, name);
		if (!field)
			return NULL;
	}

> +
> +	offset = field->offset;
> +
> +	if (field->flags & FIELD_IS_DYNAMIC) {
> +		offset = *(int *)(sample->raw_data + field->offset);
> +		offset &= 0xffff;
> +	}
> +
> +	return sample->raw_data + offset;
> +}
> +
> +u64 perf_evsel__intval(struct perf_evsel *evsel, struct perf_sample *sample,
> +		       const char *name)
> +{
> +	struct format_field *field = pevent_find_field(evsel->tp_format, name);
> +	u64 val;
> +
> +        if (!field)
> +                return 0;

Ditto.

Thanks,
Namhyung

> +
> +	val = pevent_read_number(evsel->tp_format->pevent,
> +				 sample->raw_data + field->offset, field->size);
> +	return val;
> +
> +}