mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: Matthias Goergens <matthias.goergens@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,  Andi Shyti <andi.shyti@kernel.org>,
	linux-i2c@vger.kernel.org,  linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] i2c: ocores: delete adapter before disabling controller
Date: Wed, 04 Nov 2026 11:20:09 +0100	[thread overview]
Message-ID: <87pkwkkiee.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20261102080327.1466598-1-matthias.goergens@gmail.com> (Matthias Goergens's message of "Mon, 2 Nov 2026 16:03:27 +0800")

>>>>> "Matthias" == Matthias Goergens <matthias.goergens@gmail.com> writes:

 > ocores_i2c_remove() clears the core's enable bits before it calls
 > i2c_del_adapter().  Deleting the adapter removes its client devices,
 > and some client drivers talk to their device while being removed:
 > lm75_remove(), for example, tries to write the sensor's original
 > configuration back.  With the core disabled, such a transfer cannot
 > work; in interrupt mode it times out after a second and the write is
 > lost.

 > Delete the adapter first, then disable the core.

 > Sashiko, the AI review bot, pointed this out while reviewing an
 > unrelated ocores patch.

 > Link: https://lore.kernel.org/all/20260813153155.3953577-1-ruoyuw560@gmail.com/
 > Link: https://sashiko.dev/#/patchset/20260813153155.3953577-1-ruoyuw560@gmail.com
 > Fixes: 18f98b1e3147 ("[PATCH] i2c: New bus driver for the OpenCores I2C controller")
 > Signed-off-by: Matthias Goergens <matthias.goergens@gmail.com>

Acked-by: Peter Korsgaard <peter@korsgaard.com>

-- 
Bye, Peter Korsgaard

      reply	other threads:[~2026-11-04 10:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-02  8:03 Matthias Goergens
2026-11-04 10:20 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pkwkkiee.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=andi.shyti@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthias.goergens@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®