From: Jonathan Corbet <corbet@lwn.net>
To: Omokefe Emmanuel Onanaroghene <emmaonana18@gmail.com>,
peterz@infradead.org, elver@google.com, bvanassche@acm.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: skhan@linuxfoundation.org, rdunlap@infradead.org,
mchehab@kernel.org, aleksandr.loktionov@intel.com,
kees@kernel.org, emmaonana18@gmail.com, tudor.ambarus@linaro.org
Subject: Re: [PATCH] docs: kdoc: parse context_lock_struct() as struct declaration
Date: Tue, 29 Sep 2026 17:06:41 -0600 [thread overview]
Message-ID: <87pkxvwtby.fsf@trenco.lwn.net> (raw)
In-Reply-To: <20260925234054.128477-1-emmaonana18@gmail.com>
Omokefe Emmanuel Onanaroghene <emmaonana18@gmail.com> writes:
> kernel-doc fails to parse struct declarations wrapped in
> context_lock_struct(), e.g. struct debugfs_cancellation:
>
> include/linux/debugfs.h:245 ... error: Cannot parse struct or union!
>
> Add a struct transform that expands context_lock_struct() to a plain
> struct declaration, and apply the struct transforms to the whole
> declaration before split_struct_proto(), matching what dump_var() and
> dump_function() already do for their prototypes. The member-only
> transform in dump_struct() is then redundant.
>
> Add a regression test for the debugfs_cancellation declaration.
>
> Fixes: 6e530e2e3119 ("debugfs: Make debugfs_cancellation a context lock struct")
> Signed-off-by: Omokefe Emmanuel Onanaroghene <emmaonana18@gmail.com>
> ---
> tools/lib/python/kdoc/kdoc_parser.py | 11 +++++++----
> tools/lib/python/kdoc/xforms_lists.py | 1 +
> tools/unittests/test_kdoc_parser.py | 26 ++++++++++++++++++++++++++
> 3 files changed, 34 insertions(+), 4 deletions(-)
Applied, thanks.
jon
prev parent reply other threads:[~2026-09-29 23:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 23:40 Omokefe Emmanuel Onanaroghene
2026-09-26 0:14 ` Bart Van Assche
2026-09-26 4:56 ` Randy Dunlap
2026-09-26 9:54 ` Omokefe Emmanuel Onanaroghene
2026-09-26 15:16 ` Jonathan Corbet
2026-09-26 16:24 ` Omokefe Emmanuel Onanaroghene
2026-09-26 16:35 ` Jonathan Corbet
2026-09-26 18:41 ` Randy Dunlap
2026-09-28 10:47 ` Marco Elver
2026-09-28 15:18 ` Loktionov, Aleksandr
2026-09-28 17:23 ` Randy Dunlap
2026-09-29 23:06 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pkxvwtby.fsf@trenco.lwn.net \
--to=corbet@lwn.net \
--cc=aleksandr.loktionov@intel.com \
--cc=bvanassche@acm.org \
--cc=elver@google.com \
--cc=emmaonana18@gmail.com \
--cc=kees@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=skhan@linuxfoundation.org \
--cc=tudor.ambarus@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®