From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C45BB3B42FC for ; Thu, 16 Jul 2026 08:05:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784189121; cv=none; b=SqhZjwTsD5qS4eIVd8Uovs2qo5vrcUc+/5Fqgsbz1eFjOzrnE8XP3QoosgHVC5m1XEZziJLizwT70A5i6CRNbF1yX85ulVihdRcQ3y6AU93obcM2cWW1/VjeZFxDAYSSB4/0PRASJO0nCpLVT58a8oiZrCyL2nQ9Yt8CVbh4eYs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784189121; c=relaxed/simple; bh=o/IiuftlIE7C9HKU8ZvKSagZWxbftIXpW9Uph86Qqw8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=stkIESEhX+hLrjGP1Jdmj61RIAz0tEncti14V0NIn7TcqgMo7fGdMm8ztgfYrfXW0oCmbhEwCqkYo/xQupy/5INQdMdcyD1LpAln8ndKXixaTwlp8haCSfq86up/jbQvl5LPHYB48mf9oZjQ/+As8ynwSL38R9STM8xDZM+ymaE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=IRD/IcD7; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=FmSXf9zr; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IRD/IcD7"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="FmSXf9zr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784189118; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+Yikf99/9Ld+d4W8zaFV+rGr++MhANQSN5nr7zBuh1o=; b=IRD/IcD71SGApWmrEWuUQNiSJNBTnbcgJTiwin8dW1upSVz0yXPH50MrPqssaj4wfZZaw3 traMixLxqYdhyF1nmsIdv6FrWqz7QoWgulH39j6MK2gRQt2JqjoNdelNEnLtum+ZIcBuCA CwUGw6BZwCONT6+blhDs/aM36vjOzMw= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-488-latn_4ByN1-OwEfAqgP94A-1; Thu, 16 Jul 2026 04:05:16 -0400 X-MC-Unique: latn_4ByN1-OwEfAqgP94A-1 X-Mimecast-MFC-AGG-ID: latn_4ByN1-OwEfAqgP94A_1784189115 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-492488f8583so90981475e9.2 for ; Thu, 16 Jul 2026 01:05:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1784189115; x=1784793915; darn=vger.kernel.org; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=+Yikf99/9Ld+d4W8zaFV+rGr++MhANQSN5nr7zBuh1o=; b=FmSXf9zrU0ajEQ3+VRMVys4a0bGZjFIUNcv6RS8BzhT8C5JsyhihR/UEawWpTz6zsN zqVqzcEQBCRMiUR/Qpi6YE2YdKLe38w27EiKg+qZ38Nga24gsHz8F0/DoSi0jwoZEmbI mPMTM9l+hkBshWcroP4zQHsXx0fJLQZz/9mt9e1NWmwQYtgjBqBwx2VITQwNVk83KKyR F0zpyjKk6+jM9FGjnxrwoJpgxQirKoQaIBFVmVZosqNHT08yFxYoCTCkXaHyES5LDbtN enSm6BqScpuIiMGdcX6KdBFseAz8SG2tbGfRPgqbptMVKdROeNeYM2pnmrUR2nhDpuz/ 5wPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784189115; x=1784793915; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=+Yikf99/9Ld+d4W8zaFV+rGr++MhANQSN5nr7zBuh1o=; b=UczOM9nhDbNOM3WH2j2HOXzyzD7xYTaUV0iOGpip0DSkk/kKj0kY+xUPqut+/0cDj+ GBihPZ0LF34lZ3tNXinpzdemuTyk5yga8hfqWKJinnQ+K74jdtz9qebH6Qd/ppku9Peh OL9zuuZxdhQNl1cs9f8CCAqRp/88Rv2sFxU1vOK97+QegiUdnuMk+McsqR7UPqp5VPwJ CFbJ/Fy3SmuSHW4QGD2X2swlY744ihq8x14KgVGnmnkUIG+lRZjrlRkeoZEe3xTOmBn5 zBh5ZLCu4qwU20HIzbKTfjDdvnfOcCvTuLSl4KTFhsJpQUdA5StCexVf9JCxgnoPghDY auUg== X-Forwarded-Encrypted: i=1; AHgh+RolUZwRQd1cL0y/NIwVrUP38sO9AH5vFaXL8xRdaaTGfP7dmuyj3wK1zvfofn8/7Fed1n9EaOpZFwYUAPQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwUcghOv05k9Tk9xGMF8GiXaOBlAyS8ztyNiBmlyp6Gpl4mBltQ sXeF4aj0nhm6O6ljod4vZMkeRIfxRnxDWNd6WFfUX5opcRxiyQLbzU8a+4UFsxC9i0RjoXPDvV7 oi/W4+W9o2fih9301N9RJ1Dk0hYxKV6BBu0vqLBcOMhziplf2YRzvlUgvKKMh1EAxzw== X-Gm-Gg: AfdE7clqbFGJx9+4LlgBDD47hU4YTYTQpP6vR0KPtaWpMP/3NlO+6H1s0A5oZCANJ8i cpGnmStUdPaJAbHrNKRF+RlVSAP8gHwt1GXClyM1DMybl2gHWRAEHsxYyqdRZtbHFSc9QKjoJb7 01GmFeYJrlM/7HBWNt9BEygJ5vIBbtE+nfELhzGEHYv+xpm6mcqzypIzU+etRBRkSAEcAEdiMl0 r/9Aulnc5s4NDCyxG4oT/sD4TXEco4fVCv18Jx0hovnJMrW5GUPmqN7ceNU/fZes5Se0hEcPy9D gSvE7imQ/PTGnhqIpRFuCYEYqinaAykCJtlQYti26Y5NvnVYsMtSW9oXJE/Yi16lgmWSf2oXrKV LC9ncHO4AHkDtnCAcX3DcTtRV5BABeG8rNA8xm/18826bBu4ffWX7EoeAabc= X-Received: by 2002:a05:600c:4fc4:b0:493:9cb3:53fc with SMTP id 5b1f17b1804b1-495389d2bb0mr108778295e9.11.1784189114945; Thu, 16 Jul 2026 01:05:14 -0700 (PDT) X-Received: by 2002:a05:600c:4fc4:b0:493:9cb3:53fc with SMTP id 5b1f17b1804b1-495389d2bb0mr108777405e9.11.1784189113925; Thu, 16 Jul 2026 01:05:13 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f4634e0d9sm21740351f8f.2.2026.07.16.01.05.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2026 01:05:13 -0700 (PDT) From: Javier Martinez Canillas To: Iker Pedrosa , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel test robot , Iker Pedrosa Subject: Re: [PATCH] drm/solomon: remove unneeded variables in blit functions In-Reply-To: <20260709-fix-ssd130x-v1-1-1272cb3dc85e@gmail.com> References: <20260709-fix-ssd130x-v1-1-1272cb3dc85e@gmail.com> Date: Thu, 16 Jul 2026 10:05:12 +0200 Message-ID: <87pl0nbbrb.fsf@ocarina.mail-host-address-is-not-set> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Iker Pedrosa writes: Hello Iker, Thanks for the patch. > Remove unneeded 'ret' variables in ssd130x_fb_blit_rect(), > ssd132x_fb_blit_rect(), and ssd133x_fb_blit_rect() functions. > These functions initialize ret to 0 and return it unchanged, > so return 0 directly instead. > > Fixes: 2258f03989af ("drm/solomon: Move calls to drm_gem_fb_end_cpu*()") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202606301409.I0ctsf41-lkp@intel.com/ > Signed-off-by: Iker Pedrosa > --- > Fix unneeded variable warnings reported by kernel test robot in the Solomon > SSD130x driver. Three blit functions were initializing 'ret' variables to 0, > never modifying them, and then returning the unchanged value. > > The fix simplifies the code by returning 0 directly, addressing the static > analysis warnings while maintaining the same functionality. > --- > drivers/gpu/drm/solomon/ssd130x.c | 9 +++------ Reviewed-by: Javier Martinez Canillas I'll push it to drm-misc (drm-misc-next). Thanks! -- Best regards, Javier Martinez Canillas Core Platforms Red Hat