mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@kernel.org>
To: Prabhakar <prabhakar.csengg@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	Prabhakar <prabhakar.csengg@gmail.com>,
	Biju Das <biju.das.jz@bp.renesas.com>,
	Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
	Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH v2 6/6] irqchip/renesas-rzv2h: Handle ICU error IRQ and add SWPE trigger
Date: Wed, 04 Feb 2026 16:22:00 +0100	[thread overview]
Message-ID: <87pl6k1qlj.ffs@tglx> (raw)
In-Reply-To: <20260203231823.208661-7-prabhakar.mahadev-lad.rj@bp.renesas.com>

On Tue, Feb 03 2026 at 23:18, Prabhakar wrote:
> +	/* 1) Bus errors (BEISR0..3) */
> +	for (k = 0; k < ICU_NUM_BE; k++) {
> +		st = readl(base + ICU_BEISR(k));
> +		if (!st)
> +			continue;
> +
> +		writel_relaxed(st, base + ICU_BECLR(k));
> +		pr_debug("rzv2h-icu: BUS error k=%u status=0x%08x\n", k, st);

Why hiding this behind pr_debug()? That's all diagnostic information
which helps to monitor system health, no?


  reply	other threads:[~2026-02-04 15:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-03 23:18 [PATCH v2 0/6] irqchip/renesas-rzv2h: Add support to handle " Prabhakar
2026-02-03 23:18 ` [PATCH v2 1/6] irqchip/renesas-rzv2h: Use local node pointer Prabhakar
2026-02-03 23:18 ` [PATCH v2 2/6] irqchip/renesas-rzv2h: Use local device pointer in ICU probe Prabhakar
2026-02-03 23:18 ` [PATCH v2 3/6] irqchip/renesas-rzv2h: Switch to using dev_err_probe() Prabhakar
2026-02-03 23:18 ` [PATCH v2 4/6] irqchip/renesas-rzv2h: Make IRQ type handling range-aware Prabhakar
2026-02-04  6:52   ` Biju Das
2026-02-04 10:19     ` Lad, Prabhakar
2026-02-04 10:25       ` Biju Das
2026-02-04 10:31         ` Lad, Prabhakar
2026-02-04 10:41           ` Biju Das
2026-02-04 10:56             ` Lad, Prabhakar
2026-02-04 11:44               ` Biju Das
2026-02-03 23:18 ` [PATCH v2 5/6] irqchip/renesas-rzv2h: Add CA55 software interrupt support Prabhakar
2026-02-04  7:08   ` Biju Das
2026-02-04 10:23     ` Lad, Prabhakar
2026-02-03 23:18 ` [PATCH v2 6/6] irqchip/renesas-rzv2h: Handle ICU error IRQ and add SWPE trigger Prabhakar
2026-02-04 15:22   ` Thomas Gleixner [this message]
2026-02-04 15:44     ` Lad, Prabhakar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pl6k1qlj.ffs@tglx \
    --to=tglx@kernel.org \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=fabrizio.castro.jz@renesas.com \
    --cc=geert+renesas@glider.be \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=p.zabel@pengutronix.de \
    --cc=prabhakar.csengg@gmail.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®