From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00D58346E7B for ; Fri, 21 Nov 2025 14:15:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763734564; cv=none; b=hUNYs7kTxj7tG8Pi9KbR0VQZndclWwemQZAl+MlKNtls1Iea+F0EZC3+SsNPn/t9z3JSqIPOjO0r7bCZUBwptsR2y2FfCuRlDhINixRpR8czS9FxuDparAsBROlv31vJMFgR9JGWEoVPKNWEF3jnGm/ZLMsFKGL6ZCybdkFnozY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763734564; c=relaxed/simple; bh=4JatnVbWDqXQUOlO41om/YVekOVBokLBc7sC0vx5oIQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=Sw2g0MLvQ33NP4fNGVxn7e0y/fnp8RCL7A9NUfZ3sWCe53b5nTdp/eu/wTA3jBrLNCEAW4jVzDLVtEiBrDilJCisXAno4eJZmZxUTLzYKghvHTJBzS5TJIyoVCOjvBxXTIwjBI2aEVgP08s08nrGj/BJvgEw0VNE5YKIJoI4Rls= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=Jpa475cj; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="Jpa475cj" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 1CB9A4E41831; Fri, 21 Nov 2025 14:15:56 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id DC77A60719; Fri, 21 Nov 2025 14:15:55 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id E0284103721B2; Fri, 21 Nov 2025 15:15:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1763734555; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=XGIzUaLaZRVrSbPfHE//yeEGilVOdLZVqcPFbYg9Y+4=; b=Jpa475cjmBN/rq5RJWqpN3qlEofCtV5t4+twhUjga30DLpkwBlxrqi2Y86TAfN3e8h5jeM ts6fF10DTZvoLIJJyQk1Y63s1KfDIQV376h46WE2yVD/AQFIDZ9KMWNVFVOHXXTMy5VyPa fsVUZ4J2E9uFpG55jUYNS8E23WsWWRfNuZXq3U0Ezm4HOqzIl7cDOUqZW5Io5TEfw/sHAC v3pOmxEZF4PfU6ffqdv4fXUOhWHhsva+XYxGMz08HDM3kEI415zyleuTInogCy52CgGAn3 x/T4pFyU6+gtJ8Br+f/AHSn7Vpnjf1yuSbf4SDw0Sda4xXf4TgU/5zpUlfHBBA== From: Miquel Raynal To: "Rob Herring (Arm)" Cc: Richard Weinberger , Vignesh Raghavendra , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Russell King , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] mtd: nand: atmel: Defer probe if SRAM is missing In-Reply-To: <20251120-at91-probe-v2-1-8c8592f02e8e@kernel.org> (Rob Herring's message of "Thu, 20 Nov 2025 15:37:50 -0600") References: <20251120-at91-probe-v2-0-8c8592f02e8e@kernel.org> <20251120-at91-probe-v2-1-8c8592f02e8e@kernel.org> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Fri, 21 Nov 2025 15:15:51 +0100 Message-ID: <87pl9bzd2g.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Hello Rob, > diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/n= and/raw/atmel/nand-controller.c > index 83ba4ebd02d4..e60998eb754b 100644 > --- a/drivers/mtd/nand/raw/atmel/nand-controller.c > +++ b/drivers/mtd/nand/raw/atmel/nand-controller.c > @@ -2306,7 +2306,7 @@ atmel_hsmc_nand_controller_init(struct atmel_hsmc_n= and_controller *nc) > "atmel,nfc-sram", 0); > if (!nc->sram.pool) { > dev_err(nc->base.dev, "Missing SRAM\n"); > - return -ENOMEM; > + return -EPROBE_DEFER; I am totally fine with the idea of probe deferral, however I think the policy is to avoid making noise when this happens. The dev_err() call is no longer relevant there. You can either lower it to dev_dbg() manually or, at your convenience, return with: return dev_err_probe(nc->base.dev, "Missing SRAM\n", -EPROBE_DEFER); Thanks, Miqu=C3=A8l