From: Takashi Iwai <tiwai@suse.de>
To: Erick Karanja <karanja99erick@gmail.com>
Cc: perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] ALSA: usb: qcom: Adjust mutex unlock order
Date: Fri, 18 Jul 2025 14:26:17 +0200 [thread overview]
Message-ID: <87pldx7kie.wl-tiwai@suse.de> (raw)
In-Reply-To: <20250718070309.441282-1-karanja99erick@gmail.com>
On Fri, 18 Jul 2025 09:03:08 +0200,
Erick Karanja wrote:
>
> The mutexes qdev_mutex and chip->mutex are acquired in that order
> throughout the driver. To preserve proper lock hierarchy and avoid
> potential deadlocks, they must be released in the reverse
> order of acquisition.
>
> This change reorders the unlock sequence to first release chip->mutex
> followed by qdev_mutex, ensuring consistency with the locking pattern.
>
> Fixes: e2710ea98124 ("staging: sound: Adjust mutex unlock order")
This commit ID doesn't exist, and the commit summary doesn't sound
right. You need to put the commit to be fixed with the commit summary
of that commit instead of your own.
Please resubmit with the proper Fixes tag.
thanks,
Takashi
prev parent reply other threads:[~2025-07-18 12:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-18 7:03 Erick Karanja
2025-07-18 12:26 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pldx7kie.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=karanja99erick@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®