From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F3E4C7EE23 for ; Mon, 5 Jun 2023 16:01:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233758AbjFEQBC (ORCPT ); Mon, 5 Jun 2023 12:01:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233183AbjFEQBA (ORCPT ); Mon, 5 Jun 2023 12:01:00 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20D36CD for ; Mon, 5 Jun 2023 09:01:00 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D5B9821B7F; Mon, 5 Jun 2023 16:00:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1685980858; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kz6sLOsH45BCwrRvdZKj8xXLLyH+JJthA2WE7AVjTTs=; b=BKmWgUcvERsKiBEtTcA+niVWA6C1J3EXGrQUJySrRBq//5X8R+3dB8VZ99/ndLJ1QT4cc+ 7GxfC6rMlpuLJorIRG+3tQuZ0pz/CgMy2BDxM+Rm1lmj2WgkcagJystSjr1wMt/zEtxtV5 VSMP1lkg663hsd85L9lwXp8ZBBxFBc4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1685980858; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kz6sLOsH45BCwrRvdZKj8xXLLyH+JJthA2WE7AVjTTs=; b=8VuC1kdTGAAfxgLAZdavOpiTYTW+i4pHmz79O0KJBSciMEhFURRi459WgxK7xjVlFeUeXZ e4iqzULbmkp4o3Cw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A6910139C7; Mon, 5 Jun 2023 16:00:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id JL65J7oGfmQXCAAAMHmgww (envelope-from ); Mon, 05 Jun 2023 16:00:58 +0000 Date: Mon, 05 Jun 2023 18:00:58 +0200 Message-ID: <87pm69hpad.wl-tiwai@suse.de> From: Takashi Iwai To: Stefan Binding Cc: Jaroslav Kysela , Takashi Iwai , , , Subject: Re: [PATCH v2 3/3] ALSA: hda/realtek: Delete cs35l41 component master during free In-Reply-To: <20230605152855.448115-4-sbinding@opensource.cirrus.com> References: <20230605152855.448115-1-sbinding@opensource.cirrus.com> <20230605152855.448115-4-sbinding@opensource.cirrus.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 05 Jun 2023 17:28:55 +0200, Stefan Binding wrote: > > This ensures that the driver is properly cleaned up when freed. > > Signed-off-by: Stefan Binding > --- > sound/pci/hda/patch_realtek.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index 7b5f194513c7b..e3774903918fe 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -6757,6 +6757,8 @@ static void cs35l41_generic_fixup(struct hda_codec *cdc, int action, const char > else > spec->gen.pcm_playback_hook = comp_generic_playback_hook; > break; > + case HDA_FIXUP_ACT_FREE: > + component_master_del(dev, &comp_master_ops); > } Don't forget to add break here. thanks, Takashi