From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CF09CCA47E for ; Fri, 10 Jun 2022 10:12:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347370AbiFJKMX (ORCPT ); Fri, 10 Jun 2022 06:12:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244063AbiFJKMV (ORCPT ); Fri, 10 Jun 2022 06:12:21 -0400 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5611EC1EEA; Fri, 10 Jun 2022 03:12:19 -0700 (PDT) Received: (Authenticated sender: peter@korsgaard.com) by mail.gandi.net (Postfix) with ESMTPSA id 791571BF205; Fri, 10 Jun 2022 10:12:12 +0000 (UTC) Received: from peko by dell.be.48ers.dk with local (Exim 4.94.2) (envelope-from ) id 1nzbch-002yue-5W; Fri, 10 Jun 2022 12:12:11 +0200 From: Peter Korsgaard To: "Neeli, Srinivas" Cc: Alexandre Belloni , Srinivas Neeli , "a.zummo@towertech.it" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "michal.simek@xilinx.com" , "sgoud@xilinx.com" , "shubhraj@xilinx.com" , "neelisrinivas18@gmail.com" , "devicetree@vger.kernel.org" , "linux-rtc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "git@xilinx.com" Subject: Re: [PATCH V6 2/2] rtc: zynqmp: Add calibration set and get support References: <20220609140833.1784738-1-srinivas.neeli@xilinx.com> <20220609140833.1784738-2-srinivas.neeli@xilinx.com> <87r13x28o4.fsf@dell.be.48ers.dk> <87mtel287y.fsf@dell.be.48ers.dk> Date: Fri, 10 Jun 2022 12:12:11 +0200 In-Reply-To: (Srinivas Neeli's message of "Fri, 10 Jun 2022 10:02:47 +0000") Message-ID: <87pmjgyghw.fsf@dell.be.48ers.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Neeli," == Neeli, Srinivas writes: Hi, >> >> Where do you see that? ug1085 rev2.2 still lists: >> >> >> >> Programming Sequences >> >> init rtc >> >> 1. Write the value 0019_8231h into the calibration register, CALIB_WRITE. >> >> >> >> > This is a very weird value. Last time I had a look, I couldn't find an > >> explanation for it. >> >> Agreed. I am not arguing that it is sensible, I just wondered where this new >> value comes from? >> > This information is missing in our TRM, as per the internal RTC IP > design specification document, the calibration value should be crystal > clock frequency minus one. > For a crystal oscillator of 32.768KHz(0x8000) frequency, the calibration value will be 0x7FFF. > Will update TRM with the required information. Ok, great! Please put this change in a separate commit from the get/set logic. -- Bye, Peter Korsgaard