From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5382C48BDF for ; Fri, 18 Jun 2021 08:15:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6CF4A6121D for ; Fri, 18 Jun 2021 08:15:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232801AbhFRIRp (ORCPT ); Fri, 18 Jun 2021 04:17:45 -0400 Received: from mga01.intel.com ([192.55.52.88]:42471 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232163AbhFRIRn (ORCPT ); Fri, 18 Jun 2021 04:17:43 -0400 IronPort-SDR: wxHc2b2PbL2Z3eIn58pDmNasBlryz180HKPk0P5aBvqDZE8mpi3xENinUQ/Yl64w0Gz4pJ7ESd Xd5qEo+F+WVQ== X-IronPort-AV: E=McAfee;i="6200,9189,10018"; a="228041669" X-IronPort-AV: E=Sophos;i="5.83,283,1616482800"; d="scan'208";a="228041669" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jun 2021 01:15:20 -0700 IronPort-SDR: GhhtatfQ/voVXHKGuquDYJLyX5JoHfQQrL+zgp2nFsMIwuz0GWe1zyAUngtEuR/E2o8Vvl/Pzj yoY4Gispk+Nw== X-IronPort-AV: E=Sophos;i="5.83,283,1616482800"; d="scan'208";a="485604188" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.239.159.119]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jun 2021 01:15:18 -0700 From: "Huang, Ying" To: Oscar Salvador Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yang Shi , Dave Hansen , Yang Shi , Michal Hocko , Wei Xu , Dan Williams , David Hildenbrand Subject: Re: [PATCH -V8 04/10] mm/migrate: make migrate_pages() return nr_succeeded References: <20210618061537.434999-1-ying.huang@intel.com> <20210618061537.434999-5-ying.huang@intel.com> <20210618075328.GA23470@linux> Date: Fri, 18 Jun 2021 16:15:15 +0800 In-Reply-To: <20210618075328.GA23470@linux> (Oscar Salvador's message of "Fri, 18 Jun 2021 09:53:33 +0200") Message-ID: <87pmwjpp0s.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Oscar Salvador writes: > On Fri, Jun 18, 2021 at 02:15:31PM +0800, Huang Ying wrote: >> From: Yang Shi >> >> The migrate_pages() returns the number of pages that were not migrated, >> or an error code. When returning an error code, there is no way to know >> how many pages were migrated or not migrated. >> >> In the following patch, migrate_pages() is used to demote pages to PMEM >> node, we need account how many pages are reclaimed (demoted) since page >> reclaim behavior depends on this. Add *nr_succeeded parameter to make >> migrate_pages() return how many pages are demoted successfully for all >> cases. >> >> Signed-off-by: Yang Shi >> Signed-off-by: Dave Hansen >> Signed-off-by: "Huang, Ying" >> Reviewed-by: Yang Shi >> Cc: Michal Hocko >> Cc: Wei Xu >> Cc: Dan Williams >> Cc: David Hildenbrand >> Cc: osalvador > > I thought we all agreed on making nr_succeed an optional argument [1]. > It reduced the churn quite a lot. > > [1] https://patchwork.kernel.org/comment/24104453/ Sorry. Forget changing this. Will change it in the next version. Best Regards, Huang, Ying