From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751775AbdJYHhQ (ORCPT ); Wed, 25 Oct 2017 03:37:16 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:36619 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751546AbdJYHhP (ORCPT ); Wed, 25 Oct 2017 03:37:15 -0400 From: Gregory CLEMENT To: Antoine Tenart Cc: tglx@linutronix.de, marc.zyngier@arm.com, jason@lakedaemon.net, andrew@lunn.ch, sebastian.hesselbarth@gmail.com, thomas.petazzoni@free-electrons.com, miquel.raynal@free-electrons.com, nadavh@marvell.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] irqchip/irq-mvebu-gicp: add missing spin_lock init References: <20171025072326.21030-1-antoine.tenart@free-electrons.com> Date: Wed, 25 Oct 2017 09:37:03 +0200 In-Reply-To: <20171025072326.21030-1-antoine.tenart@free-electrons.com> (Antoine Tenart's message of "Wed, 25 Oct 2017 09:23:26 +0200") Message-ID: <87po9b4r1c.fsf@free-electrons.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Antoine, On mer., oct. 25 2017, Antoine Tenart wrote: > A spin lock is used in the irq-mvebu-gicp driver, but it is never > initialized. This patch adds the missing spin_lock_init() call in the > driver's probe function. > > Fixes: a68a63cb4dfc ("irqchip/irq-mvebu-gicp: Add new driver for Marvell GICP") > Signed-off-by: Antoine Tenart You could add the "Cc: stable@vger.kernel.org" flag so the previous kernels can also benefit of this fix. Besides this this patch looks obviously correct. Reviewed-by: Gregory CLEMENT Thanks, Gregory > --- > drivers/irqchip/irq-mvebu-gicp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/irqchip/irq-mvebu-gicp.c b/drivers/irqchip/irq-mvebu-gicp.c > index b283fc90be1e..17a4a7b6cdbb 100644 > --- a/drivers/irqchip/irq-mvebu-gicp.c > +++ b/drivers/irqchip/irq-mvebu-gicp.c > @@ -194,6 +194,7 @@ static int mvebu_gicp_probe(struct platform_device *pdev) > return -ENOMEM; > > gicp->dev = &pdev->dev; > + spin_lock_init(&gicp->spi_lock); > > gicp->res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > if (!gicp->res) > -- > 2.14.2 > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com