From: Jani Nikula <jani.nikula@linux.intel.com>
To: David Binderman <dcb314@hotmail.com>,
"patrik.r.jakobsson\@gmail.com" <patrik.r.jakobsson@gmail.com>,
"airlied\@linux.ie" <airlied@linux.ie>,
"dri-devel\@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: drivers/gpu/drm/gma500/mdfld_intel_display.c:102:37: warning: bitwise comparison always evaluates to false [-Wtautological-compare]
Date: Tue, 24 Oct 2017 11:54:05 +0300 [thread overview]
Message-ID: <87po9dhqoi.fsf@intel.com> (raw)
In-Reply-To: <VI1PR0802MB2336FE2CC4B113AD21AAB1CD9C460@VI1PR0802MB2336.eurprd08.prod.outlook.com>
On Mon, 23 Oct 2017, David Binderman <dcb314@hotmail.com> wrote:
> Hello there,
>
> Source code is
>
> if ((temp & PIPEACONF_PIPE_STATE) == 1)
> break;
>
> but
>
> $ fgrep PIPEACONF_PIPE_STATE `find drivers/gpu/drm/gma500 -name \*.h -print`
> drivers/gpu/drm/gma500/psb_intel_reg.h:#define PIPEACONF_PIPE_STATE (1 << 30)
> $
>
> Suggest new code
>
> if ((temp & PIPEACONF_PIPE_STATE) != 0)
> break;
Suggest looking at latest sources. ;)
Fixed by 67a3b63a54cb ("drm: gma500: fix logic error").
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
next parent reply other threads:[~2017-10-24 8:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <VI1PR0802MB2336FE2CC4B113AD21AAB1CD9C460@VI1PR0802MB2336.eurprd08.prod.outlook.com>
2017-10-24 8:54 ` Jani Nikula [this message]
[not found] ` <HE1PR0802MB233133226542350C51A759889C470@HE1PR0802MB2331.eurprd08.prod.outlook.com>
2017-10-24 9:46 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87po9dhqoi.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@linux.ie \
--cc=dcb314@hotmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrik.r.jakobsson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome