From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751485AbdGRPXn (ORCPT ); Tue, 18 Jul 2017 11:23:43 -0400 Received: from mga05.intel.com ([192.55.52.43]:10336 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751439AbdGRPXm (ORCPT ); Tue, 18 Jul 2017 11:23:42 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,378,1496127600"; d="scan'208";a="1173957185" From: Alexander Shishkin To: Alexey Budankov , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo Cc: Andi Kleen , Kan Liang , Dmitri Prokhorov , Valery Cherepennikov , Mark Rutland , David Carrillo-Cisneros , Stephane Eranian , linux-kernel Subject: Re: [PATCH v5 4/4]: perf/core: complete replace of lists by rb trees for pinned and flexible groups at perf_event_context In-Reply-To: References: <871spdx6jj.fsf@ashishki-desk.ger.corp.intel.com> User-Agent: Notmuch/0.23.7 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Tue, 18 Jul 2017 18:23:34 +0300 Message-ID: <87pocxvkeh.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Alexey Budankov writes: >> You probably also want to explain this change, for example change the >> @group_list description, saying that something else links into it now. >> > > The whole patch as a single commit, attached to patch v5 4/4, may provide > the complete view of suggested changes. No, each patch has to be readable on its own. If one has to jump between patches to figure out what's going on, it's already discouraging. The point of submitting a patch, on the other hand, is to encourage the reviewers to read on. Regards, -- Alex