From: ebiederm@xmission.com (Eric W. Biederman)
To: Andrei Vagin <avagin@virtuozzo.com>
Cc: Andrey Vagin <avagin@openvz.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Linux Containers <containers@lists.linux-foundation.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [REVIEW][PATCH] mount: In propagate_umount handle overlapping mount propagation trees
Date: Fri, 21 Oct 2016 14:26:19 -0500 [thread overview]
Message-ID: <87pomtec6c.fsf@xmission.com> (raw)
In-Reply-To: <20161020213052.GA25226@outlook.office365.com> (Andrei Vagin's message of "Thu, 20 Oct 2016 14:30:53 -0700")
Andrei Vagin <avagin@virtuozzo.com> writes:
>> Barring some stupid mistake this looks like it fixes both the performance
>> and the correctness issues I was able to spot earlier. Andrei if you
>> could give this version a look over I would appreciate it.
>
> Eric, could you try out this script:
[snip script]
> It hangs up on my host with this patch.
Ugh. I am seeing the hang as well digging into it.
Thanks for keeping me honest.
Eric
next prev parent reply other threads:[~2016-10-21 19:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 23:26 [PATCH] [v3] mount: dont execute propagate_umount() many times for same mounts Andrei Vagin
2016-10-13 17:14 ` Eric W. Biederman
2016-10-13 19:53 ` [RFC][PATCH] mount: In mark_umount_candidates and __propogate_umount visit each mount once Eric W. Biederman
2016-10-13 21:46 ` Andrei Vagin
2016-10-14 2:31 ` Andrey Vagin
2016-10-14 2:45 ` Eric W. Biederman
2016-10-14 18:29 ` [RFC][PATCH v2] " Eric W. Biederman
2016-10-18 2:40 ` Andrei Vagin
2016-10-18 6:49 ` Eric W. Biederman
2016-10-19 3:46 ` [REVIEW][PATCH] mount: In propagate_umount handle overlapping mount propagation trees Eric W. Biederman
2016-10-20 21:30 ` Andrei Vagin
2016-10-21 19:26 ` Eric W. Biederman [this message]
2016-10-22 19:42 ` [RFC][PATCH v2] " Eric W. Biederman
2016-10-25 20:58 ` Andrei Vagin
2016-10-25 21:45 ` Eric W. Biederman
2016-10-25 23:41 ` Andrei Vagin
2016-10-26 1:42 ` Eric W. Biederman
2016-11-01 6:14 ` Andrei Vagin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pomtec6c.fsf@xmission.com \
--to=ebiederm@xmission.com \
--cc=avagin@openvz.org \
--cc=avagin@virtuozzo.com \
--cc=containers@lists.linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome