From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
To: Will Deacon <will.deacon@arm.com>
Cc: Vince Weaver <vincent.weaver@maine.edu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>
Subject: Re: perf: WARNING: kernel/events/core.c:4893 perf_mmap_close
Date: Wed, 24 Aug 2016 14:44:12 +0300 [thread overview]
Message-ID: <87pooyl7cj.fsf@ashishki-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20160824091905.GA16944@arm.com>
Will Deacon <will.deacon@arm.com> writes:
> A little bit of digging suggests that the preempt count isn't balanced
> across the call to perf_pmu_output_stop from perf_mmap_close. Further
> digging revealed the unbalanced get_cpu_ptr in __perf_pmu_output_stop.
> Fix below!
Oh gee, that's embarrassing. Thanks!
> This patch uses this_cpu_ptr instead of get_cpu_ptr, since preemption is
> already disabled by the caller.
>
> Fixes: 95ff4ca26c49 ("perf/core: Free AUX pages in unmap path")
> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Signed-off-by: Will Deacon <will.deacon@arm.com>
Reviewed-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Regards,
--
Alex
next prev parent reply other threads:[~2016-08-24 11:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-08 20:22 Vince Weaver
2016-08-09 5:15 ` Alexander Shishkin
2016-08-09 12:43 ` Vince Weaver
2016-08-09 12:53 ` Vince Weaver
2016-08-12 17:17 ` Vince Weaver
2016-08-12 17:54 ` Alexander Shishkin
2016-08-23 15:12 ` Will Deacon
2016-08-23 17:06 ` Peter Zijlstra
2016-08-23 17:08 ` Alexander Shishkin
2016-08-24 9:19 ` Will Deacon
2016-08-24 11:44 ` Alexander Shishkin [this message]
2016-08-24 13:13 ` [tip:perf/urgent] perf/core: Use this_cpu_ptr() when stopping AUX events tip-bot for Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pooyl7cj.fsf@ashishki-desk.ger.corp.intel.com \
--to=alexander.shishkin@linux.intel.com \
--cc=acme@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=vincent.weaver@maine.edu \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®