From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932284AbcHKLH5 (ORCPT ); Thu, 11 Aug 2016 07:07:57 -0400 Received: from ozlabs.org ([103.22.144.67]:51633 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752330AbcHKLHz convert rfc822-to-8bit (ORCPT ); Thu, 11 Aug 2016 07:07:55 -0400 From: Michael Ellerman To: Radim =?utf-8?B?S3LEjW3DocWZ?= , Paolo Bonzini Cc: kvm@vger.kernel.org, Mahesh Salgaonkar , linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org, Paul Mackerras , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] powerpc: move hmi.c to arch/powerpc/kvm/ In-Reply-To: <87vaz8t62z.fsf@concordia.ellerman.id.au> References: <1470224194-15412-1-git-send-email-pbonzini@redhat.com> <20160810184127.GA27257@potion> <87vaz8t62z.fsf@concordia.ellerman.id.au> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Thu, 11 Aug 2016 21:07:48 +1000 Message-ID: <87popftvgb.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Michael Ellerman writes: > Radim Krčmář writes: > >> 2016-08-03 13:36+0200, Paolo Bonzini: >>> hmi.c functions are unused unless sibling_subcore_state is nonzero, and >>> that in turn happens only if KVM is in use. So move the code to >>> arch/powerpc/kvm/, putting it under CONFIG_KVM_BOOK3S_64_HANDLER >>> rather than CONFIG_PPC_BOOK3S_64. The sibling_subcore_state is also >>> included in struct paca_struct only if KVM is supported by the kernel. >>> >>> Cc: Paul Mackerras >>> Cc: Michael Ellerman >>> Cc: Mahesh Salgaonkar >>> Cc: linuxppc-dev@lists.ozlabs.org >>> Cc: kvm-ppc@vger.kernel.org >>> Cc: kvm@vger.kernel.org >>> Signed-off-by: Paolo Bonzini >>> --- >>> It would be nice to have this in 4.8, to minimize any 4.9 conflicts. >>> Build-tested only, with and without KVM enabled. >> >> If you agree with the change, would you prefer to have this patch merged >> through the PowerPC tree? > > Yeah I'll pull it into my fixes branch. And then I pulled it out again: (.text+0x157fc): undefined reference to `.wait_for_subcore_guest_exit' (.text+0x15834): undefined reference to `.wait_for_tb_resync' make[1]: *** [vmlinux] Error 1 http://kisskb.ellerman.id.au/kisskb/buildresult/12775422/ cheers