From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751144AbcGLS0g (ORCPT ); Tue, 12 Jul 2016 14:26:36 -0400 Received: from anholt.net ([50.246.234.109]:60977 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751092AbcGLS0e (ORCPT ); Tue, 12 Jul 2016 14:26:34 -0400 From: Eric Anholt To: Thierry Reding Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, David Airlie Subject: Re: [PATCH] drm/panel: Remove the get_timings() function. In-Reply-To: <20160711123737.GC14709@ulmo.ba.sec> References: <1464808681-1970-1-git-send-email-eric@anholt.net> <20160711123737.GC14709@ulmo.ba.sec> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Tue, 12 Jul 2016 11:26:29 -0700 Message-ID: <87poqi67ca.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Thierry Reding writes: > On Wed, Jun 01, 2016 at 12:18:01PM -0700, Eric Anholt wrote: >> It appears to have no callers. >>=20 >> Signed-off-by: Eric Anholt >> --- >> drivers/gpu/drm/panel/panel-simple.c | 18 ------------------ >> include/drm/drm_panel.h | 4 ---- >> 2 files changed, 22 deletions(-) > > Looks like I never replied to this, though I remember at least making up > the reply in my head. > > The reason why I'd like to keep this is that it's technically the right > interface for display drivers to use. It was introduced in order to fix > some of the short-comings of ->get_modes(), though it seems like there > simply hasn't been a need so far for drivers to do this. OK. That makes some sense then. I was writing a new panel driver, and it was confusing to have this unused code in panel-simple that I was deriving from. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJXhTZWAAoJELXWKTbR/J7oHCIP/0wn3fI+vBhNPQVuN1hhmsjL R9gN+X+m1xzlED003j2apw/heuOGCpJwlNtkRvzu8TeKjsaISO3eAvrYuJHv1s8T M8w7eANJLtgLpBqP65wXd81HNOKK1JqT/vBN1YvS59cu+Yehc4fTfDii48JSSoAs OzosUZo8ZDMq+1Dc/F6RqdHuex5a9nyUbfHIPDiyMYDipPPGrLMq3fMqMCWKURcC sHTiejBLx/6rMce91Jw9TFT8zBemc5/WNeKsM9cb74GOjd+jswxH+pW+nWonE5uU 9Sc3Hm6BqsiH6LrH/PM4ItWh6BJ3hwT/dkRI9t29UjddPM6eKUJCYJw1Jhd7w17b JMckEsz++PSgTHd+JVPprBPHhvuKOwNZAbYGFTM3RbIWaeuDRI7X4BQZswKE7sjA HEK+JIM5UL5/R7EA55L7up3sPBKiyDcBfJJztuf1Aklk3FWm1wr8LtOHcmhi2Llp enWMtuWuzystoNZ8cK/wV7SzRLjbPFlGyeltPZU7Gj21WBIxBkK8l3rN9X2s4htI nDAQB9DkYhvwfC5Dp2vVHMca3rJOeKMkLqdXwQbSj/6AnK9MoN86NK+XfyS7kYaM BsJtC9etcYO70cTVpyt/mxNr73nTVg6i0Slp8pZ4h3glFzTdHR8HBxCzr49N8t9R PLG9NgXvvSYgbuQCxmMY =HjP0 -----END PGP SIGNATURE----- --=-=-=--