From: Kalle Valo <kvalo@codeaurora.org>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
hannes@stressinduktion.org, nbd@nbd.name,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv4 wl-drv-next 2/2] mt7601u: use linux/bitfield.h
Date: Tue, 05 Jul 2016 16:16:20 +0300 [thread overview]
Message-ID: <87poqs2pjv.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1467718979-20029-3-git-send-email-jakub.kicinski@netronome.com> (Jakub Kicinski's message of "Tue, 5 Jul 2016 12:42:59 +0100")
Jakub Kicinski <jakub.kicinski@netronome.com> writes:
> Use the newly added linux/bitfield.h.
>
> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
[...]
> +#define MT76_SET FIELD_PUT
> +#define MT76_GET FIELD_GET
This define is useless now, I would just remove it entirely. But you can
do that in a follow up patch.
--
Kalle Valo
next prev parent reply other threads:[~2016-07-05 13:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 11:42 [PATCHv4 wl-drv-next 0/2] register-field manipulation macros Jakub Kicinski
2016-07-05 11:42 ` [PATCHv4 wl-drv-next 1/2] add basic " Jakub Kicinski
2016-07-05 11:42 ` [PATCHv4 wl-drv-next 2/2] mt7601u: use linux/bitfield.h Jakub Kicinski
2016-07-05 13:16 ` Kalle Valo [this message]
2016-07-05 13:24 ` [PATCHv4 wl-drv-next 0/2] register-field manipulation macros Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87poqs2pjv.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=hannes@stressinduktion.org \
--cc=jakub.kicinski@netronome.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®